BBC: Blead Breaks Data::Clone and others

[cjg-cguevara]

This is a bug report for perl from "Carlos Guevara" carlos@carlosguevara.com,
generated with the help of perlbug 1.43 running under perl 5.37.6.

---

BBC: Blead Breaks Data::Clone

Please see http://fast-matrix.cpantesters.org/?dist=Data::Clone

---

Flags

• category=core
• severity=low

---

Perl configuration

Site configuration information for perl 5.37.9:

Configured by cpan at Wed Feb  8 22:16:32 EST 2023.

Summary of my perl5 (revision 5 version 37 subversion 9) configuration:
  Commit id: fe7859256d3a8e646ec90c7313a105c8d273db32
  Platform:
    osname=linux
    osvers=5.15.90-0-lts
    archname=x86_64-linux-thread-multi
    uname='linux cjg-alpine3 5.15.90-0-lts #1-alpine smp wed, 25 jan 2023 08:18:30 +0000 x86_64 linux '
    config_args='-des -Dprefix=~/bin/perl-blead -Dscriptdir=~/bin/perl-blead/bin -Dusedevel -Duse64bitall -Duseithreads'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=define
    usemultiplicity=define
    use64bitint=define
    use64bitall=define
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
  Compiler:
    cc='cc'
    ccflags ='-D_REENTRANT -D_GNU_SOURCE -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
    optimize='-O2'
    cppflags='-D_REENTRANT -D_GNU_SOURCE -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong'
    ccversion=''
    gccversion='12.2.1 20220924'
    gccosandvers=''
    intsize=4
    longsize=8
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=3
    ivtype='long'
    ivsize=8
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=8
    prototype=define
  Linker and Libraries:
    ld='cc'
    ldflags =' -fstack-protector-strong -L/usr/local/lib'
    libpth=/usr/lib /usr/local/lib /lib
    libs=-lpthread -ldb -ldl -lm -lcrypt -lutil -lc
    perllibs=-lpthread -ldl -lm -lcrypt -lutil -lc
    libc=/usr/lib/libc.a
    so=so
    useshrplib=false
    libperl=libperl.a
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=so
    d_dlsymun=undef
    ccdlflags='-Wl,-E'
    cccdlflags='-fPIC'
    lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'


---
@INC for perl 5.37.9:
    /home/cpan/bin/perl-blead/lib/site_perl/5.37.9/x86_64-linux-thread-multi
    /home/cpan/bin/perl-blead/lib/site_perl/5.37.9
    /home/cpan/bin/perl-blead/lib/5.37.9/x86_64-linux-thread-multi
    /home/cpan/bin/perl-blead/lib/5.37.9

---
Environment for perl 5.37.9:
    HOME=/home/cpan
    LANG=C.UTF-8
    LANGUAGE (unset)
    LC_COLLATE=C
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/cpan/bin/perl-blead/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
    PERL_BADLANG (unset)
    SHELL=/bin/bash

[andk]

Bisect leads me to v5.37.8-34-g7e2d91e6d3:

commit 7e2d91e6d3a09e2ebb61242bb18ff95d30d9560d
Author: Tony Cook <tony@develop-help.com>
Date:   Wed Dec 7 16:17:45 2022 +1100

    toke.c: deprecation warning for ' as a package separator

[andk]

Also affected: SPROUT/DBM-Deep-2.0016.tar.gz

[demerphq]

Wouldn't surprise if everything from sprout uses ' as a package separator. He is/was fond of it and said as much a few times.

[jkeenan]

@tonycoz, the breaking commit was said to be first in a series supporting implementation of an RFC. Are we sufficiently committed to this series such that we can say, "CPAN authors you must adapt now"? (If I were one of the author/maintainers affected by this problem, I would only want to adapt my code once.)

[demerphq]

@jkeenan the next step is to remove support entirely.

[jkeenan]

@jkeenan the next step is to remove support entirely.

This module and DBM::Deep are both using use warnings FATAL => 'all'; in their test suites,
e.g., https://metacpan.org/release/SPROUT/DBM-Deep-2.0016/source/t/01_basic.t#L2. How should we advise their maintainers to proceed?

[demerphq]

As far as I know sprout is Father Chrysotomos. Really he should know better than to use fatal warnings. Regardless we should push BBC fixes to remove use of the single apostrophe package separators. He has said in the past he likes them however.

[jkeenan]

Data::Clone uses inc::Module::Install in its Makefile.PL. That rules me out as someone to submit a pull request for that module :-(

[demerphq]

On Thu, 9 Feb 2023 at 14:20, James E Keenan ***@***.***> wrote: Data::Clone uses inc::Module::Install in its Makefile.PL. That rules me out as someone to submit a pull request for that module :-(

Patch pushed as gfx/p5-Data-Clone#3

…

[demerphq]

Also affected: SPROUT/DBM-Deep-2.0016.tar.gz

patch pushed as robkinyon/dbm-deep#22

[tonycoz]

@tonycoz, the breaking commit was said to be first in a series supporting implementation of an RFC. Are we sufficiently committed to this series such that we can say, "CPAN authors you must adapt now"? (If I were one of the author/maintainers affected by this problem, I would only want to adapt my code once.)

As @demerphq pointed out, only one adaption is needed: removing use of ' as a package name separator.

In this case I've simply implemented the RFC, unless the PSC decides otherwise the next (and last) in the series will be in 5.40, where this will likely produce an error rather than a warning (should it throw on cases where ' was accepted as part of a symbol, or just not allow the ' resulting in syntax error in most cases).