BBC breaks Crypt::SMIME

[eserte]

MIKAGE/Crypt-SMIME-0.30.tar.gz does not compile anymore since approx. perl 5.41.5, see http://fast-matrix.cpantesters.org/?dist=Crypt-SMIME%200.30
(There's a pass with cygwin+5.41.6, which might be a special case)

The compilatation error looks like this:

"/opt/perl-5.41.9/bin/perl5.41.9" "/opt/perl-5.41.9/lib/5.41.9/ExtUtils/xsubpp"  -typemap '/opt/perl-5.41.9/lib/5.41.9/ExtUtils/typemap' -typemap '/home/cpansand/.cpan/build/2025030221/Crypt-SMIME-0.30-0/typemap'  SMIME.xs > SMIME.xsc
Unparseable XSUB parameter: 'char* /*CLASS*/' in SMIME.xs, line 443
Makefile:386: recipe for target 'SMIME.c' failed

[Leont]

That looks like the ParseXS changes @iabyn has been working on

[jkeenan]

That looks like the ParseXS changes @iabyn has been working on

Indeed! Bisecting with the following invocation:

perl Porting/bisect.pl \
--module=Crypt::SMIME \
--start=v5.41.4 \
--end=v5.41.5

... pointed to a399a49 as the breaking commit:

a399a4923c7f15aa1aa5bdb38a5dccf59ef51678 is the first bad commit
commit a399a4923c7f15aa1aa5bdb38a5dccf59ef51678
Author: David Mitchell <davem@iabyn.com>
Date:   Mon Sep 23 18:52:11 2024 +0100
Commit:     David Mitchell <davem@iabyn.nospamdeletethisbit.com>
CommitDate: Fri Oct 18 11:12:17 2024 +0100

    ParseXS: refactor: XSUB signature-processing

@iabyn, can you take a look? Thanks.

[iabyn]

On Wed, Mar 05, 2025 at 03:45:37AM -0800, James E Keenan wrote: ... pointed to a399a49 as the breaking commit: Author: David Mitchell ***@***.***> ParseXS: refactor: XSUB signature-processing

This is showing up a bug in the distro, which I've reported as follows: https://rt.cpan.org/Ticket/Display.html?id=162293

…

------------------------------------------------------------------------- Crypt-SMIME is failing to build against recent bleadperls, due a change to the way ExtUtils::ParseXS parses function signatures. The offending line 443 in SMIME.xs is new(char* /*CLASS*/) which appears to be trying to express that a class parameter is passed to the method but will be ignored. This isn't valid XS syntax, but until recently the XS parser had a bug where it would silently ignore parameter declarations which it couldn't parse. A better-supported technique for ignoring a parameter is to give it a name but no type, so changing the declaration to new(class) should fix the issue.

-- "You may not work around any technical limitations in the software" -- Windows Vista license

[eserte]

The distribution got a new release 0.31, which looks fixed for this particular issue, see RT and https://fast2-matrix.cpantesters.org/?dist=Crypt-SMIME%200.31

This issue may be closed.

[jkeenan]

The distribution got a new release 0.31, which looks fixed for this particular issue, see RT and https://fast2-matrix.cpantesters.org/?dist=Crypt-SMIME%200.31

This issue may be closed.

Confirmed; thanks; closing.