t/run/todo.t: Test lost part of description when un-TODO-ed

[jkeenan]

Observed while reviewing #23540 ...

Back in December daf7baa removed the TODO stipulation from the final unit test in t/run/todo.t.

$ gitshowf daf7baa8d0a
commit daf7baa8d0a4823897bfd307c641e2e02d18ff33
Author:     Karl Williamson <khw@cpan.org>
AuthorDate: Fri Dec 6 15:24:45 2024 -0700
Commit:     Karl Williamson <khw@cpan.org>
CommitDate: Fri Dec 6 15:29:58 2024 -0700

    run/todo.t: Remove todo of now passing test

diff --git a/t/run/todo.t b/t/run/todo.t
index 59041d7aaa..e20d33120a 100644
--- a/t/run/todo.t
+++ b/t/run/todo.t
@@ -65,8 +65,7 @@ TODO: {
     is($?, 0, "No assertion failure");
 }
 
-TODO: {
-    local $::TODO = 'GH 16627';
+{
     fresh_perl('use re "eval";
                 my @r;
                 for$0(qw(0 0)){push@r,qr/@r(?{})/};',

Prior to this commit, when run through the harness the output would have looked like this:

ok 1 - GH \#16894
...
ok 6 - No assertion failure # TODO GH 16627
ok
...

Now, it looks like this:

$ cd t;./perl harness -v run/todo.t; cd -

ok 1 - GH \#16894
...
ok 14 - No assertion failure
ok

There are several unit tests in this file whose description is No assertion failure. Since the others are still TODO-ed, the harness displays their GH issue numbers on the basis of local $TODO. In the above test, however, the GH number no longer appears. I suggest the test description(s) be modified to include [GH 16627] or similar.

@khwilliamson, can you take a look? Thanks.

[khwilliamson]

Thank you for finding these. I believe #23572 together with #23545 fix this