pp.c build problem with Dusethreads 5.42 (perl5-5.43.2 as well)

[endocrantz]

RHEL 9.4 using gcc 11.4.1 or 15.2

configure.gnu -Dusethreads

pp.c:4139:50: error: invalid application of 'sizeof' to incomplete type 'struct crypt_data'

Can not build with thread support.

RHEL 9.6 gcc 11.5 seems to build alright with thread support. My cluster is 9.4, though.

Suggestions welcome

[jkeenan]

RHEL 9.4 using gcc 11.4.1 or 15.2

configure.gnu -Dusethreads

pp.c:4139:50: error: invalid application of 'sizeof' to incomplete type 'struct crypt_data'

Can not build with thread support.

RHEL 9.6 gcc 11.5 seems to build alright with thread support. My cluster is 9.4, though.

Suggestions welcome

Several questions:

1. How are you getting the perl source code from which you are trying to configure and build? From a production release (tarball)? In a checkout from our git repository (GH)? What version of perl are you working from?

2. Is there some special reason why you are using configure.gnu to configure? This program was last updated in 2010, which suggests very few people are using it. (I've been working on the core distribution since about 2011, but today was the first time I ran it.)

3. Suppose you try to configure with the following invocation:

$ sh ./Configure -des -Dusedevel -Dusethreads -Dcc=gcc && \
    make test_prep && make test_harness

What kind of results do you get?

4. Can you supply the output of perl -V for any already installed perl that you originally configured with configure.gnu?

[Leont]

configure.gnu -Dusethreads

Are you using perl-cross perhaps?

pp.c:4139:50: error: invalid application of 'sizeof' to incomplete type 'struct crypt_data'

Can not build with thread support.

Threads enable reentrant APIs, in this case crypt_r. What libc are you using? Is your ccflags (see the config.sh file) including both -D_REENTRANT and -D_GNU_SOURCE?

[mauke]

Aside:

2. Is there some special reason why you are using configure.gnu to configure? This program was last updated in 2010, which suggests very few people are using it. (I've been working on the core distribution since about 2011, but today was the first time I ran it.)

configure.gnu is a very small wrapper around Configure. It basically just translates between different option formats, so I don't expect it to need frequent updates.

[endocrantz]

Aside:

2. Is there some special reason why you are using configure.gnu to configure? This program was last updated in 2010, which suggests very few people are using it. (I've been working on the core distribution since about 2011, but today was the first time I ran it.)

configure.gnu is a very small wrapper around Configure. It basically just translates between different option formats, so I don't expect it to need frequent updates.

No, this is just a result of my stumbling around. I just used Configure per jkeenan suggestions and am building from that.
Thank you!

[endocrantz]

For jkeenan, thank you:

The result from: sh ./Configure -des -Dusedevel -Dusethreads -Dcc=gcc && make test_prep && make test_harness

gcc -c -DPERL_CORE -D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -std=c99 -O2 -Wall -Werror=pointer-arith -Werror=vla -Wextra -Wno-long-long -Wno-declaration-after-statement -Wc++-compat -Wwrite-strings pp.c pp.c: In function ‘Perl_pp_crypt’: pp.c:4139:50: error: invalid application of ‘sizeof’ to incomplete type ‘struct crypt_data’ 4139 | (struct crypt_data *)safemalloc(sizeof(struct crypt_data));

No change, unfortunately. The following is output from perl -V from a spack version without threads enabled:

[aevans@compute-13-1 perl5-5.42.0]$ perl -V
Summary of my perl5 (revision 5 version 42 subversion 0) configuration:

  Platform:
    osname=linux
    osvers=5.14.0-427.70.1.el9_4.x86_64
    archname=x86_64-linux
    uname='linux compute-13-1 5.14.0-427.70.1.el9_4.x86_64 #1 smp preempt_dynamic mon may 19 15:16:42 edt 2025 x86_64 x86_64 x86_64 gnulinux '
    config_args='-des -Dprefix=/projects/spack/spack-1.0.1/opt/spack/linux-broadwell/perl-5.42.0-uupsn63y6mztxovgykfm4fclasn2rsms -Dlocincpth=/projects/spack/spack-1.0.1/opt/spack/linux-broadwell/gdbm-1.23-gq4afj5t6j4bjysx3ifcuk4badvaa77j/include -Dloclibpth=/projects/spack/spack-1.0.1/opt/spack/linux-broadwell/gdbm-1.23-gq4afj5t6j4bjysx3ifcuk4badvaa77j/lib -Accflags=-DAPPLLIB_EXP=\"/projects/spack/spack-1.0.1/opt/spack/linux-broadwell/perl-5.42.0-uupsn63y6mztxovgykfm4fclasn2rsms/lib/perl5\" -Duseshrplib'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=undef
    usemultiplicity=undef
    use64bitint=define
    use64bitall=define
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
  Compiler:
    cc='/usr/bin/gcc'
    ccflags =' -DAPPLLIB_EXP="/projects/spack/spack-1.0.1/opt/spack/linux-broadwell/perl-5.42.0-uupsn63y6mztxovgykfm4fclasn2rsms/lib/perl5" -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/projects/spack/spack-1.0.1/opt/spack/linux-broadwell/gdbm-1.23-gq4afj5t6j4bjysx3ifcuk4badvaa77j/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2'
    optimize='-O2'
    cppflags='-DAPPLLIB_EXP="/projects/spack/spack-1.0.1/opt/spack/linux-broadwell/perl-5.42.0-uupsn63y6mztxovgykfm4fclasn2rsms/lib/perl5" -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/projects/spack/spack-1.0.1/opt/spack/linux-broadwell/gdbm-1.23-gq4afj5t6j4bjysx3ifcuk4badvaa77j/include'
    ccversion=''
    gccversion='11.4.1 20231218 (Red Hat 11.4.1-4)'
    gccosandvers=''
    intsize=4
    longsize=8
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=3
    ivtype='long'
    ivsize=8
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=8
    prototype=define
  Linker and Libraries:
    ld='/usr/bin/gcc'
    ldflags =' -fstack-protector-strong -L/projects/spack/spack-1.0.1/opt/spack/linux-broadwell/gdbm-1.23-gq4afj5t6j4bjysx3ifcuk4badvaa77j/lib'
    libpth=/usr/lib /projects/spack/spack-1.0.1/opt/spack/linux-broadwell/gdbm-1.23-gq4afj5t6j4bjysx3ifcuk4badvaa77j/lib /usr/lib64 /usr/local/lib /usr/local/lib64
    libs=-lpthread -lgdbm -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
    perllibs=-lpthread -ldl -lm -lcrypt -lutil -lc
    libc=/lib/../lib64/libc.so.6
    so=so
    useshrplib=true
    libperl=libperl.so
    gnulibc_version='2.34'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=so
    d_dlsymun=undef
    ccdlflags='-Wl,-E -Wl,-rpath,/projects/spack/spack-1.0.1/opt/spack/linux-broadwell/perl-5.42.0-uupsn63y6mztxovgykfm4fclasn2rsms/lib/5.42.0/x86_64-linux/CORE'
    cccdlflags='-fPIC'
    lddlflags='-shared -O2 -L/projects/spack/spack-1.0.1/opt/spack/linux-broadwell/gdbm-1.23-gq4afj5t6j4bjysx3ifcuk4badvaa77j/lib -fstack-protector-strong'


Characteristics of this binary (from libperl):
  Compile-time options:
    HAS_LONG_DOUBLE
    HAS_STRTOLD
    HAS_TIMES
    PERLIO_LAYERS
    PERL_COPY_ON_WRITE
    PERL_DONT_CREATE_GVSV
    PERL_HASH_FUNC_SIPHASH13
    PERL_HASH_USE_SBOX32
    PERL_MALLOC_WRAP
    PERL_OP_PARENT
    PERL_PRESERVE_IVUV
    PERL_USE_SAFE_PUTENV
    USE_64_BIT_ALL
    USE_64_BIT_INT
    USE_LARGE_FILES
    USE_LOCALE
    USE_LOCALE_COLLATE
    USE_LOCALE_CTYPE
    USE_LOCALE_NUMERIC
    USE_LOCALE_TIME
    USE_PERLIO
    USE_PERL_ATOF
  Built under linux
  Compiled at Sep 16 2025 16:36:54
  %ENV:
    PERL5LIB="/usr/local/share/perl5:"
    PERL_BADLANG="0"
  @INC:
    /usr/local/share/perl5
    /projects/spack/spack-1.0.1/opt/spack/linux-broadwell/perl-5.42.0-uupsn63y6mztxovgykfm4fclasn2rsms/lib/perl5
    /projects/spack/spack-1.0.1/opt/spack/linux-broadwell/perl-5.42.0-uupsn63y6mztxovgykfm4fclasn2rsms/lib/site_perl/5.42.0/x86_64-linux
    /projects/spack/spack-1.0.1/opt/spack/linux-broadwell/perl-5.42.0-uupsn63y6mztxovgykfm4fclasn2rsms/lib/site_perl/5.42.0
    /projects/spack/spack-1.0.1/opt/spack/linux-broadwell/perl-5.42.0-uupsn63y6mztxovgykfm4fclasn2rsms/lib/5.42.0/x86_64-linux
    /projects/spack/spack-1.0.1/opt/spack/linux-broadwell/perl-5.42.0-uupsn63y6mztxovgykfm4fclasn2rsms/lib/5.42.0

[endocrantz]

I don't know how I closed this or marked it as needs triage, neither was intentional

[Leont]

In your config.sh file, what is the value i_crypt?

[endocrantz]

In your config.sh file, what is the value i_crypt?

i_crypt='undef'

[Leont]

i_crypt='undef'

Yeah that explains. That means it won't include crypt.h, which is where struct crypt_data is defined. I think you can override that with a -Di_crypt argument to Configure, but that should be picked up automatically.

The real question is why it doesn't pick it up automatically. You do have a /usr/include/crypt.h file, right? It may help to save the output of Configure, for me it includes:

crypt() found.
<crypt.h> found.
crypt_r() found.

[endocrantz]

The OS thinks libxcrypt-devel is installed, but upon further investigation:

rpm -V libxcrypt-devel
missing /usr/include/crypt.h
...

After re-installation perl now builds as we expected.

I very much appreciate your all having taken the time here. We can close this out.