Skip to content

str_to_version: Use utf8_to_uv_or_die #23081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

str_to_version: Use utf8_to_uv_or_die #23081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions toke.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2351,8 +2351,8 @@ Perl_str_to_version(pTHX_ SV *sv)
NV retval = 0.0;
NV nshift = 1.0;
STRLEN len;
const char *start = SvPV_const(sv,len);
const char * const end = start + len;
const U8 *start = (const U8 *) SvPV_const(sv,len);
const U8 * const end = start + len;
const bool utf = cBOOL(SvUTF8(sv));

PERL_ARGS_ASSERT_STR_TO_VERSION;
Expand All @@ -2361,9 +2361,9 @@ Perl_str_to_version(pTHX_ SV *sv)
STRLEN skip;
UV n;
if (utf)
n = utf8n_to_uvchr((U8*)start, len, &skip, 0);
n = utf8_to_uv_or_die(start, end, &skip);
else {
n = *(U8*)start;
n = *start;
skip = 1;
}
retval += ((NV)n)/nshift;
Expand Down