Search::Dict: clean up code #23119
Merged
Search::Dict: clean up code #23119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Search::Dict is dual-life, blead-first. This p.r. is failing some tests on perl-5.8. There has not been a fresh CPAN release since 2012. I don't know if we have a Standard Operating Procedure for a case like this. |
- Remove 'require 5.000'. In theory, this would give a nice runtime error message when run under perl4; in practice, this file doesn't even parse as perl4 due to 'use strict', 'our', and '->' method calls. - Use numeric comparison with $], not string comparison. (In practice, this would probably only start failing once we reach perl 10, but still.) - Don't repeatedly check $fc_available at runtime. Just define a fallback fc() in terms of lc() if CORE::fc is not available. - Add missing $key argument to sample code in SYNOPSIS. This fixes <https://rt.cpan.org/Ticket/Display.html?id=97189>.
Contributor
Author
|
@jkeenan Thanks, should be fixed now. |
jkeenan
approved these changes
Mar 15, 2025
Contributor
jkeenan
left a comment
jkeenan
left a comment
There was a problem hiding this comment.
This module would benefit from what could be called "quasi-coverage analysis," i.e., examination to see whether all functionality described in the documentation is exercised or even implemented in the code. But we can save that for a different ticket. This looks fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require 5.000. In theory, this would give a nice runtime error message when run under perl4; in practice, this file doesn't even parse as perl4 due touse strict,our, and->method calls.$], not string comparison. (In practice, this would probably only start failing once we reach perl 10, but still.)$fc_availableat runtime. Just define a fallback fc() in terms of lc() if CORE::fc is not available.$keyargument to sample code in SYNOPSIS. This fixes https://rt.cpan.org/Ticket/Display.html?id=97189.