t/porting/diag.t: fix oversights in message extraction regex #23123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- recognize the short form() as well as Perl_form()
- accept/ignore spaces between `Perl_croak(` and `aTHX_`
With this change, diag.t now recognizes several diagnostic messages that
went undetected previously (note the space before `aTHX_`):
- perlio.c
Perl_croak( aTHX_
"%s (%" UVuf ") does not match %s (%" UVuf ")",
Perl_croak( aTHX_
"%s (%" UVuf ") smaller than %s (%" UVuf ")",
- regcomp_trie.c
Perl_croak( aTHX_ "error creating/fetching widecharmap entry for 0x%" UVXf, uvc );
default: Perl_croak( aTHX_ "panic! In trie construction, unknown node type %u %s", (unsigned) flags, REGNODE_NAME(flags) );
Perl_croak( aTHX_ "panic! In trie construction, no char mapping for %" IVdf, uvc );
This PR partially overlaps with Perl#23017. Merging either will cause
conflicts in the other that will have to be resolved manually.
(In particular, if this PR is merged first, the diag.t changes from
Perl#23017 can be dropped, as can some of the perldiag.pod additions. But
that PR also modifies the perlio.c messages, so their old forms added
here ("%s (%d) does not match %s (%d)", "%s (%d) smaller than %s (%d)")
will have to be deleted.)
khwilliamson
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perl_croak(andaTHX_With this change, diag.t now recognizes several diagnostic messages that went undetected previously (note the space before
aTHX_):perlio.c
regcomp_trie.c
This PR partially overlaps with #23017. Merging either will cause conflicts in the other that will have to be resolved manually.
(In particular, if this PR is merged first, the diag.t changes from #23017 can be dropped, as can some of the perldiag.pod additions. But that PR also modifies the perlio.c messages, so their old forms added here ("%s (%d) does not match %s (%d)", "%s (%d) smaller than %s (%d)") will have to be deleted.)