turn croak("%s", "foo") into croak("foo") #23124
Merged
+25
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no point in using a separate format string if the whole error message is written right next to it. Not only does this change lead to simpler code (passing one argument instead of two), it also exposes more error messages to t/porting/diag.t, which relies on croak's first argument to supply the message template. Also make an equivalent change to S_open_script, which passes a constant string in the form of an err variable that is not used anywhere else. (It used to be, but that code was deleted in commit 5bc7d00.)
khwilliamson
approved these changes
Mar 16, 2025
Leont
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no point in using a separate format string if the whole error message is written right next to it. Not only does this change lead to simpler code (passing one argument instead of two), it also exposes more error messages to t/porting/diag.t, which relies on croak's first argument to supply the message template.
Also make an equivalent change to
S_open_script, which passes a constant string in the form of anerrvariable that is not used anywhere else. (It used to be, but that code was deleted in commit 5bc7d00.)