Clone ReadOnly inversion list before modifying it #23125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unicode-defined properties are kept in inversion lists in read-only memory. Attempting to modify them will result in a segfault. The new Unicode 16.0 has some empty properties that need to be inverted before use in some cases. This situation has not occurred before. The inversion code that gets called presumes it has a modifiable SV and inverts in-place. This segfaults. Normally, no inversion is needed, and the properties are used as-is, and no problem arises. The solution here is to create a clone, and then invert that.
mauke
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unicode-defined properties are kept in inversion lists in read-only memory. Attempting to modify them will result in a segfault. The new Unicode 16.0 has some empty properties that need to be inverted before use in some cases. This situation has not occurred before. The inversion code that gets called presumes it has a modifiable SV and inverts in-place. This segfaults.
Normally, no inversion is needed, and the properties are used as-is, and no problem arises.
The solution here is to create a clone, and then invert that.