Remove redundant code that handles mg_obj of PERL_MAGIC_symtab #23138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This seems to have been forgotten in c2b1997. With that context this change makes complete sense. |
Leont
approved these changes
Mar 20, 2025
The (badly-named) PERL_MAGIC_symtab no longer uses the `mg_obj` field, ever since it was reshaped by c2b1997 This magic is only applied in one place (at time of writing, toke.c line 10711) with the `obj` field set to NULL. Therefore, there is no point having code in `dump.c` to print it if non-NULL, nor in `sv.c` to special-case setting a non-NULL value in `sv_magicext()`.
leonerd
force-pushed
the
PERL_MAGIC_symtab-no-mg_obj
branch
from
46ee54a to
63ff8b3
Compare
Contributor
Author
|
I edited the commit message to add the context of that previous commit. Thanks for the archaeology @Leont |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (badly-named) PERL_MAGIC_symtab no longer uses the
mg_objfield. It is only applied in one place (at time of writing, toke.c line 10711) with theobjfield set to NULL. Therefore, there is no point having code indump.cto print it if non-NULL, nor insv.cto special-case setting a non-NULL value insv_magicext().