Skip to content

Remove redundant code that handles mg_obj of PERL_MAGIC_symtab #23138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Remove redundant code that handles mg_obj of PERL_MAGIC_symtab #23138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions dump.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2393,12 +2393,6 @@ Perl_do_sv_dump(pTHX_ I32 level, PerlIO *file, SV *sv, I32 nest, I32 maxnest, bo
#endif
(void)PerlIO_putc(file, '\n');
}
{
MAGIC * const mg = mg_find(sv, PERL_MAGIC_symtab);
if (mg && mg->mg_obj) {
Perl_dump_indent(aTHX_ level, file, " PMROOT = 0x%" UVxf "\n", PTR2UV(mg->mg_obj));
}
}
{
const char * const hvname = HvNAME_get(sv);
if (hvname) {
Expand Down
1 change: 0 additions & 1 deletion sv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5895,7 +5895,6 @@ Perl_sv_magicext(pTHX_ SV *const sv, SV *const obj, const int how,
how == PERL_MAGIC_arylen ||
how == PERL_MAGIC_regdata ||
how == PERL_MAGIC_regdatum ||
how == PERL_MAGIC_symtab ||
(SvTYPE(obj) == SVt_PVGV &&
(GvSV(obj) == sv || GvHV(obj) == (const HV *)sv
|| GvAV(obj) == (const AV *)sv || GvCV(obj) == (const CV *)sv
Expand Down
Loading