Skip to content

Dumper.xs: Use PERL_MAGIC_vstring symbolic constant rather than 'V' character literal #23158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Dumper.xs: Use PERL_MAGIC_vstring symbolic constant rather than 'V' character literal #23158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/Data-Dumper/Dumper.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ our ( $Indent, $Trailingcomma, $Purity, $Pad, $Varname, $Useqq, $Terse, $Freezer
our ( @ISA, @EXPORT, @EXPORT_OK, $VERSION );

BEGIN {
$VERSION = '2.191'; # Don't forget to set version and release
$VERSION = '2.192'; # Don't forget to set version and release
# date in POD below!

@ISA = qw(Exporter);
Expand Down
4 changes: 2 additions & 2 deletions dist/Data-Dumper/Dumper.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1386,7 +1386,7 @@ DD_dump(pTHX_ SV *val, const char *name, STRLEN namelen, SV *retval, HV *seenhv,
sv_catpvs(retval, "undef");
}
#ifdef SvVOK
else if (SvMAGICAL(val) && (mg = mg_find(val, 'V'))) {
else if (SvMAGICAL(val) && (mg = mg_find(val, PERL_MAGIC_vstring))) {
# if !defined(PL_vtbl_vstring) && PERL_VERSION_LT(5,17,0)
SV * const vecsv = sv_newmortal();
# if PERL_VERSION_LT(5,10,0)
Expand Down Expand Up @@ -1703,7 +1703,7 @@ Data_Dumper__vstring(sv)
#ifdef SvVOK
const MAGIC *mg;
RETVAL =
SvMAGICAL(sv) && (mg = mg_find(sv, 'V'))
SvMAGICAL(sv) && (mg = mg_find(sv, PERL_MAGIC_vstring))
? newSVpvn((const char *)mg->mg_ptr, mg->mg_len)
: &PL_sv_undef;
#else
Expand Down
Loading