Skip to content

Switch away from Windows Server 2019 for CI #23350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Leont merged 4 commits into from
Jun 2, 2025
Merged

Switch away from Windows Server 2019 for CI #23350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f307c84
Skip two ping tests on cygwin
Leont Jun 1, 2025
1308632
Run mingw64 and cygwin tests on latest Windows Server
Leont Jun 1, 2025
8527732
Run msvc tests on latest Windows Server 2025
Leont Jun 1, 2025
a817b52
Properly mark new MSVC as v143
Leont Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions .github/workflows/testsuite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# - CI_FORCE_LINUX_I386: if set to a true value: run the 'linux-i386' job;
# - CI_FORCE_INSTALL: if set to a true value: run the 'install' job;
# - CI_FORCE_MACOS: if set to a true value: run the 'smoke-macos-14' job;
# - CI_FORCE_MSVC142: if set to a true value: run the 'windows-msvc142' job;
# - CI_FORCE_MSVC143: if set to a true value: run the 'windows-msvc143' job;
# - CI_FORCE_MINGW64: if set to a true value: run the 'mingw64' job;
# - CI_FORCE_CYGWIN: if set to a true value: run the 'cygwin' job;
# - CI_FORCE_MINITEST: if set to a true value: run the 'miniperl' job;
Expand Down Expand Up @@ -139,7 +139,7 @@ jobs:
ci_force_linux_i386: ${{ steps.ci_config.outputs.ci_force_linux_i386 }}
ci_force_install: ${{ steps.ci_config.outputs.ci_force_install }}
ci_force_macos: ${{ steps.ci_config.outputs.ci_force_macos }}
ci_force_msvc142: ${{ steps.ci_config.outputs.ci_force_msvc142 }}
ci_force_msvc143: ${{ steps.ci_config.outputs.ci_force_msvc143 }}
ci_force_mingw64: ${{ steps.ci_config.outputs.ci_force_mingw64 }}
ci_force_cygwin: ${{ steps.ci_config.outputs.ci_force_cygwin }}
ci_force_minitest: ${{ steps.ci_config.outputs.ci_force_minitest }}
Expand All @@ -160,7 +160,7 @@ jobs:
CI_FORCE_LINUX_I386: ${{ vars.CI_FORCE_LINUX_I386 }}
CI_FORCE_INSTALL: ${{ vars.CI_FORCE_INSTALL }}
CI_FORCE_MACOS: ${{ vars.CI_FORCE_MACOS }}
CI_FORCE_MSVC142: ${{ vars.CI_FORCE_MSVC142 }}
CI_FORCE_MSVC143: ${{ vars.CI_FORCE_MSVC143 }}
CI_FORCE_MINGW64: ${{ vars.CI_FORCE_MINGW64 }}
CI_FORCE_CYGWIN: ${{ vars.CI_FORCE_CYGWIN }}
CI_FORCE_MINITEST: ${{ vars.CI_FORCE_MINITEST }}
Expand All @@ -174,7 +174,7 @@ jobs:
[[ -n "${CI_FORCE_LINUX_I386}" ]] && [[ "${CI_FORCE_LINUX_I386%[!0 ]*}" != "${CI_FORCE_LINUX_I386}" ]] && echo "ci_force_linux_i386=true" >> "$GITHUB_OUTPUT"
[[ -n "${CI_FORCE_INSTALL}" ]] && [[ "${CI_FORCE_INSTALL%[!0 ]*}" != "${CI_FORCE_INSTALL}" ]] && echo "ci_force_install=true" >> "$GITHUB_OUTPUT"
[[ -n "${CI_FORCE_MACOS}" ]] && [[ "${CI_FORCE_MACOS%[!0 ]*}" != "${CI_FORCE_MACOS}" ]] && echo "ci_force_macos=true" >> "$GITHUB_OUTPUT"
[[ -n "${CI_FORCE_MSVC142}" ]] && [[ "${CI_FORCE_MSVC142%[!0 ]*}" != "${CI_FORCE_MSVC142}" ]] && echo "ci_force_msvc142=true" >> "$GITHUB_OUTPUT"
[[ -n "${CI_FORCE_MSVC143}" ]] && [[ "${CI_FORCE_MSVC143%[!0 ]*}" != "${CI_FORCE_MSVC143}" ]] && echo "ci_force_msvc143=true" >> "$GITHUB_OUTPUT"
[[ -n "${CI_FORCE_MINGW64}" ]] && [[ "${CI_FORCE_MINGW64%[!0 ]*}" != "${CI_FORCE_MINGW64}" ]] && echo "ci_force_mingw64=true" >> "$GITHUB_OUTPUT"
[[ -n "${CI_FORCE_CYGWIN}" ]] && [[ "${CI_FORCE_CYGWIN%[!0 ]*}" != "${CI_FORCE_CYGWIN}" ]] && echo "ci_force_cygwin=true" >> "$GITHUB_OUTPUT"
[[ -n "${CI_FORCE_MINITEST}" ]] && [[ "${CI_FORCE_MINITEST%[!0 ]*}" != "${CI_FORCE_MINITEST}" ]] && echo "ci_force_minitest=true" >> "$GITHUB_OUTPUT"
Expand Down Expand Up @@ -457,12 +457,12 @@ jobs:
# \ V V / | ' \/ _` / _ \ V V (_-<
# \_/\_/|_|_||_\__,_\___/\_/\_//__/

windows-msvc142:
name: "Windows msvc142"
runs-on: windows-2019
windows-msvc143:
name: "Windows msvc143"
runs-on: windows-2025
timeout-minutes: 120
needs: sanity_check
if: (! cancelled() && (needs.sanity_check.outputs.run_all_jobs == 'true' || needs.sanity_check.outputs.ci_force_msvc142 == 'true'))
if: (! cancelled() && (needs.sanity_check.outputs.run_all_jobs == 'true' || needs.sanity_check.outputs.ci_force_msvc143 == 'true'))

steps:
- run: git config --global core.autocrlf false
Expand Down Expand Up @@ -491,9 +491,9 @@ jobs:
- name: Build
shell: cmd
run: |
call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
cd win32
nmake CCTYPE=MSVC142 CFG=Debug
nmake CCTYPE=MSVC143 CFG=Debug
- name: Show Config
shell: cmd
run: |
Expand All @@ -502,9 +502,9 @@ jobs:
- name: Run Tests
shell: cmd
run: |
call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
cd win32
nmake CCTYPE=MSVC142 CFG=Debug test
nmake CCTYPE=MSVC143 CFG=Debug test

# _ __ _ _
# _ __ ___ (_)_ __ __ ___ __/ /_ | || |
Expand All @@ -515,7 +515,7 @@ jobs:

mingw64:
name: "Windows mingw64"
runs-on: windows-2019
runs-on: windows-2025
timeout-minutes: 120
needs: sanity_check
if: (! cancelled() && (needs.sanity_check.outputs.run_all_jobs == 'true' || needs.sanity_check.outputs.ci_force_mingw64 == 'true'))
Expand Down Expand Up @@ -566,7 +566,7 @@ jobs:

cygwin:
name: "cygwin"
runs-on: windows-2019
runs-on: windows-2025
timeout-minutes: 120
needs: sanity_check
if: (! cancelled() && (needs.sanity_check.outputs.run_all_jobs == 'true' || needs.sanity_check.outputs.ci_force_cygwin == 'true'))
Expand Down
4 changes: 2 additions & 2 deletions dist/Net-Ping/t/450_service.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ is($p->ping("127.0.0.1"), 1, 'first port is reachable');
$p->{port_num} = $port2;

{
local $TODO = "Believed not to work on $^O" if $^O =~ /^(?:MSWin32|os390)$/;
local $TODO = "Believed not to work on $^O" if $^O =~ /^(?:MSWin32|os390|cygwin)$/;
is($p->ping("127.0.0.1"), 1, 'second port is reachable');
}

Expand Down Expand Up @@ -133,7 +133,7 @@ SKIP: {

{
local $TODO = "Believed not to work on $^O"
if $^O =~ /^(?:MSWin32|os390)$/;
if $^O =~ /^(?:MSWin32|os390|cygwin)$/;
is($p->ack(), '127.0.0.1', 'IP should be reachable');
}
}
Expand Down
Loading