From 0f04a5d4b31b0318d373c9607bf1f710c16f5e1e Mon Sep 17 00:00:00 2001 From: James E Keenan Date: Tue, 26 Aug 2025 18:00:15 -0400 Subject: [PATCH 1/2] t/op/goto.t: Remove superfluous 'exit;' statement --- t/op/goto.t | 1 - 1 file changed, 1 deletion(-) diff --git a/t/op/goto.t b/t/op/goto.t index 58c76c27e02c..182e07fce9ef 100644 --- a/t/op/goto.t +++ b/t/op/goto.t @@ -74,7 +74,6 @@ sub bar { } &bar; -exit; FINALE: is(curr_test(), 20, 'FINALE'); From f2ba7befccbf0a67d98c6077d8d38e428453bcec Mon Sep 17 00:00:00 2001 From: James E Keenan Date: Wed, 27 Aug 2025 09:54:44 -0400 Subject: [PATCH 2/2] per @mauke comment in GH 23649 The 'exit;' statement is here to ensure that bar does not return normally. (If it did, the exit would be executed, making the test fail because the rest of the planned tests wouldn't have run.) For clarity, I would recommend adding an explicit fail. --- t/op/goto.t | 2 ++ 1 file changed, 2 insertions(+) diff --git a/t/op/goto.t b/t/op/goto.t index 182e07fce9ef..230f942eeb79 100644 --- a/t/op/goto.t +++ b/t/op/goto.t @@ -74,6 +74,8 @@ sub bar { } &bar; +fail('goto bypass'); +exit; FINALE: is(curr_test(), 20, 'FINALE');