Skip to content

z/OS has fixed some of their locales, so test them #23670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
khwilliamson merged 3 commits into from
Sep 8, 2025
Merged

z/OS has fixed some of their locales, so test them #23670

khwilliamson merged 3 commits into from
Sep 8, 2025

Conversation

@khwilliamson
Copy link
Contributor

@khwilliamson khwilliamson commented Sep 2, 2025 •
edited
Loading

The IBM code page 924 (https://en.wikibooks.org/wiki/Character_Encodings/Code_Tables/EBCDIC/EBCDIC_1047) locales are broken; but others are fixed

  • This set of changes does not require a perldelta entry.

@richardleach
Copy link
Contributor

richardleach commented Sep 8, 2025

Is the commit actually saying that 924 locales are broken?

@jkeenan
Copy link
Contributor

jkeenan commented Sep 8, 2025

Is the commit actually saying that 924 locales are broken?

There is certainly a discrepancy between the Subject of the 2nd commit in this p.r.:

lib/locale.t: IBM-934 locales are broken on z/OS

... and the code added in that commit:

                          os390 => qr/ IBM-924 /ix,

But above and beyond that, do we have a way to verify that one or the other (924 vs 934) is correct? When I plug IBM-924 into DDG, I get a lot of results that talk about "IBM Power System 924", but nothing that says anything about "os390". Similarly, when I plug in "os390", the results were about "OS/390" (which Wikipedia describes as a predecessor of z/OS. Given that very few of us reading this list have access to z/OS, I wonder how we verify the proposed changes.

@khwilliamson
lib/locale.t: Broken locale now is working
e683708 
Apparently IBM has fixed this Italian locale
@khwilliamson
lib/locale.t: IBM code page 924 locales are broken on z/OS
541ba1f 
IBM products tend to view NBSP as both space and graphic; a violation of
the POSIX standard.  There is code in handy.h to compensate for this.
But locales using code page 924 are outliers, and that general code for
the platform doesn't work for them, so add them to the known bad list.

(IBM-924 is an EBCDIC version of Latin-9, ISO 8859-15)
@khwilliamson
lib/locale.t: No longer need higher failure % on os390
5bbe0ce 
The locales on os390 now have failure rates comparable to other systems.
@khwilliamson
Copy link
Contributor Author

khwilliamson commented Sep 8, 2025 •
edited
Loading

The magic phrase for things with MicroSoft and IBM is "Code Page". An internet search with that phrase and '924' turns up relevant links. https://en.wikibooks.org/wiki/Character_Encodings/Code_Tables/EBCDIC/EBCDIC_1047

And I was sloppy in my commit messages. I have since cleaned that up.

Until we get a smoker going on this platform, you'll just have to take my word for it, like I do of Craig Berry for VMS

@khwilliamson khwilliamson merged commit 47a5f10 into Perl:blead Sep 8, 2025
33 checks passed
@khwilliamson khwilliamson deleted the ebcdic_locale branch September 8, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonycoz tonycoz tonycoz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@khwilliamson @richardleach @jkeenan @tonycoz