t/test.pl: Make /dev/null available for portability #23683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonycoz
reviewed
Sep 8, 2025
t/test.pl
Outdated
Comment on lines
4
to
5
| # This sets $::IS_ASCII and $::IS_EBCDIC appropriately, and $::devnull to the | ||
| # string to use to specify /dev/null on this platform |
Contributor
There was a problem hiding this comment.
This comment's reference to "This" seems to be hanging in the middle of nowhere.
I assume you're trying to document these variables, but I don't think it belongs here, the ascii/ebcdic variables have documentation in a vague kind of way, and devnull could use the same, but I don't think it belongs before the caution here.
I'm going to look at writing a test_pl.pod since we can't use pod here and the in-comment documentation is annoying to access (and very incomplete).
Contributor
Author
There was a problem hiding this comment.
I moved the documentation to after the Note, and clarified it. This was a start on documenting what I just did, and the other package variables it sets.
This creates a variable containing the string to use to specify /dev/null portably; and documents the package variables it sets
khwilliamson
force-pushed
the
devnull
branch
from
1cc3cad to
0db1252
Compare
tonycoz
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a variable containing the string to use to specify /dev/null portably; and documents the package variables it sets