Skip to content

Modernise overloading pragma a little #23716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khwilliamson merged 1 commit into from
Sep 17, 2025
Merged

Modernise overloading pragma a little #23716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions lib/overloading.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,22 @@
package overloading;
use warnings;
package overloading 0.03;

our $VERSION = '0.02';
use v5.40;

my $HINT_NO_AMAGIC = 0x01000000; # see perl.h

require 5.010001;

sub _ops_to_nums {
my sub ops_to_nums (@ops) {
require overload::numbers;

map { exists $overload::numbers::names{"($_"}
? $overload::numbers::names{"($_"}
: do { require Carp; Carp::croak("'$_' is not a valid overload") }
} @_;
} @ops;
}

sub import {
my ( $class, @ops ) = @_;

sub import ($, @ops) {
if ( @ops ) {
if ( $^H{overloading} ) {
vec($^H{overloading} , $_, 1) = 0 for _ops_to_nums(@ops);
vec($^H{overloading} , $_, 1) = 0 for ops_to_nums(@ops);
}

if ( $^H{overloading} !~ /[^\0]/ ) {
Expand All @@ -34,12 +29,10 @@ sub import {
}
}

sub unimport {
my ( $class, @ops ) = @_;

sub unimport ($, @ops) {
if ( exists $^H{overloading} or not $^H & $HINT_NO_AMAGIC ) {
if ( @ops ) {
vec($^H{overloading} ||= '', $_, 1) = 1 for _ops_to_nums(@ops);
vec($^H{overloading} ||= '', $_, 1) = 1 for ops_to_nums(@ops);
} else {
delete $^H{overloading};
}
Expand All @@ -48,7 +41,6 @@ sub unimport {
$^H |= $HINT_NO_AMAGIC;
}

1;
__END__

=head1 NAME
Expand Down
9 changes: 3 additions & 6 deletions lib/overloading.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
#./perl

use Test::More;

no warnings 'experimental::builtin';
use builtin qw(refaddr);
use v5.40;

{
package Stringifies;
use Test::More;

package Stringifies {
use overload (
fallback => 1,
'""' => sub { "foo" },
Expand Down
Loading