Rename THING token when used for attributes #23982
Merged
+1,136
−1,126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this, toke.c and perly.y used the token name `THING` for a number of apparently totally unrelated reasons. While I haven't attempted to fix most of them, I did find that the one used for attribute lists is unrelated to the others, so I have renamed that to something more sensible and meaningful.
tonycoz
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, toke.c and perly.y used the token name
THINGfor a number of apparently totally unrelated reasons. While I haven't attempted to fix most of them, I did find that the one used for attribute lists is unrelated to the others, so I have renamed that to something more sensible and meaningful.I intend that this change should have no visible effects on anything as it should just be internal neatening and renaming. I'm relatively confident this use of
THINGwas isolated from the others due to the unique appearance of theCOLONATTRthat goes with it. But the complexities of tokenization and parsing mean I'm not 100% sure there isn't some weird twisty cornercase that I haven't noticed, and might break somewhere. We should keep an eye on CPAN test reports post-merge on this one.