Skip to content

Commit a953440

Browse files
Merge pull request #367 from PermanentOrg/feature/VSP-1643
Multiple Select File Menu - in all workspaces.
2 parents 12ab283 + 92d4ea8 commit a953440

21 files changed

+547
-1658
lines changed

app/src/main/java/org/permanent/permanent/ui/SelectionOptionsFragment.kt

Lines changed: 0 additions & 77 deletions
This file was deleted.

app/src/main/java/org/permanent/permanent/ui/myFiles/MyFilesFragment.kt

Lines changed: 12 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ import kotlinx.coroutines.launch
2828
import org.permanent.permanent.BuildConfig
2929
import org.permanent.permanent.R
3030
import org.permanent.permanent.databinding.DialogCancelUploadsBinding
31-
import org.permanent.permanent.databinding.DialogDeleteBinding
3231
import org.permanent.permanent.databinding.DialogRenameRecordBinding
3332
import org.permanent.permanent.databinding.FragmentMyFilesBinding
3433
import org.permanent.permanent.models.AccountEventAction
@@ -40,7 +39,6 @@ import org.permanent.permanent.network.models.ChecklistItem
4039
import org.permanent.permanent.ui.PREFS_NAME
4140
import org.permanent.permanent.ui.PermanentBaseFragment
4241
import org.permanent.permanent.ui.PreferencesHelper
43-
import org.permanent.permanent.ui.SelectionOptionsFragment
4442
import org.permanent.permanent.ui.Workspace
4543
import org.permanent.permanent.ui.activities.MainActivity
4644
import org.permanent.permanent.ui.archives.PARCELABLE_ARCHIVE_KEY
@@ -53,6 +51,8 @@ import org.permanent.permanent.ui.myFiles.saveToPermanent.SaveToPermanentFragmen
5351
import org.permanent.permanent.ui.openLink
5452
import org.permanent.permanent.ui.public.PublicFragment
5553
import org.permanent.permanent.ui.recordMenu.RecordMenuFragment
54+
import org.permanent.permanent.ui.recordMenu.RecordUiModel
55+
import org.permanent.permanent.ui.recordMenu.SelectionMenuFragment
5656
import org.permanent.permanent.ui.shareManagement.ShareManagementFragment
5757
import org.permanent.permanent.ui.shares.PreviewState
5858
import org.permanent.permanent.ui.shares.SHOW_SCREEN_SIMPLIFIED_KEY
@@ -84,7 +84,7 @@ class MyFilesFragment : PermanentBaseFragment() {
8484
private var saveToPermanentFragment: SaveToPermanentFragment? = null
8585
private var shareManagementFragment: ShareManagementFragment? = null
8686
private var sortOptionsFragment: SortOptionsFragment? = null
87-
private var selectionOptionsFragment: SelectionOptionsFragment? = null
87+
private var selectionMenuFragment: SelectionMenuFragment? = null
8888
private var bottomSheetFragment: ChecklistBottomSheetFragment? = null
8989
private val onRecordSelectedEvent = SingleLiveEvent<Record>()
9090
private var shouldRefreshCurrentFolder = false
@@ -346,11 +346,11 @@ class MyFilesFragment : PermanentBaseFragment() {
346346
viewModel.refreshCurrentFolder()
347347
}
348348

349-
private val showSelectionOptionsObserver = Observer<Pair<Int, Boolean>> {
350-
selectionOptionsFragment = SelectionOptionsFragment()
351-
selectionOptionsFragment?.setBundleArguments(it)
352-
selectionOptionsFragment?.show(parentFragmentManager, selectionOptionsFragment?.tag)
353-
selectionOptionsFragment?.getOnSelectionModifyRequest()?.observe(this, onSelectionModifyObserver)
349+
private val showSelectionMenuObserver = Observer<List<RecordUiModel>> {
350+
selectionMenuFragment = SelectionMenuFragment()
351+
selectionMenuFragment?.setSelectedRecords(it)
352+
selectionMenuFragment?.show(parentFragmentManager, selectionMenuFragment?.tag)
353+
selectionMenuFragment?.getOnSelectionModifyRequest()?.observe(this, onSelectionModifyObserver)
354354
}
355355

356356
private val showEditMetadataScreenObserver = Observer<MutableList<Record>> {
@@ -388,24 +388,7 @@ class MyFilesFragment : PermanentBaseFragment() {
388388
}
389389

390390
private val onSelectionModifyObserver = Observer<ModificationType> { modificationType ->
391-
if (modificationType == ModificationType.DELETE) {
392-
val dialogBinding: DialogDeleteBinding = DataBindingUtil.inflate(
393-
LayoutInflater.from(context), R.layout.dialog_delete, null, false
394-
)
395-
val alert = AlertDialog.Builder(context).setView(dialogBinding.root).create()
396-
397-
dialogBinding.tvTitle.text = getString(R.string.delete_records_title)
398-
dialogBinding.btnDelete.setOnClickListener {
399-
viewModel.onSelectionModifyBtnClick(modificationType)
400-
alert.dismiss()
401-
}
402-
dialogBinding.btnCancel.setOnClickListener {
403-
alert.dismiss()
404-
}
405-
alert.show()
406-
} else {
407-
viewModel.onSelectionModifyBtnClick(modificationType)
408-
}
391+
viewModel.onSelectionModifyBtnClick(modificationType)
409392
}
410393

411394
private val onRecordRelocateObserver = Observer<Pair<Record, ModificationType>> {
@@ -528,7 +511,7 @@ class MyFilesFragment : PermanentBaseFragment() {
528511
viewModel.getShrinkIslandRequest().observe(this, shrinkIslandRequestObserver)
529512
viewModel.getExpandIslandRequest().observe(this, expandIslandRequestObserver)
530513
viewModel.getRefreshCurrentFolderRequest().observe(this, refreshCurrentFolderObserver)
531-
viewModel.getShowSelectionOptionsRequest().observe(this, showSelectionOptionsObserver)
514+
viewModel.getShowSelectionOptionsRequest().observe(this, showSelectionMenuObserver)
532515
viewModel.getShowEditMetadataScreenRequest().observe(this, showEditMetadataScreenObserver)
533516
viewModel.getOpenChecklistBottomSheet().observe(this, openChecklistBottomSheetObserver)
534517
renameDialogViewModel.getOnRecordRenamed().observe(this, onRecordRenamed)
@@ -558,7 +541,7 @@ class MyFilesFragment : PermanentBaseFragment() {
558541
viewModel.getShrinkIslandRequest().removeObserver(shrinkIslandRequestObserver)
559542
viewModel.getExpandIslandRequest().removeObserver(expandIslandRequestObserver)
560543
viewModel.getRefreshCurrentFolderRequest().removeObserver(refreshCurrentFolderObserver)
561-
viewModel.getShowSelectionOptionsRequest().removeObserver(showSelectionOptionsObserver)
544+
viewModel.getShowSelectionOptionsRequest().removeObserver(showSelectionMenuObserver)
562545
viewModel.getShowEditMetadataScreenRequest().removeObserver(showEditMetadataScreenObserver)
563546
viewModel.getOpenChecklistBottomSheet().removeObserver(openChecklistBottomSheetObserver)
564547
bottomSheetFragment?.getOnChecklistItemClick()?.removeObserver(onChecklistItemClickObserver)
@@ -576,7 +559,7 @@ class MyFilesFragment : PermanentBaseFragment() {
576559
recordMenuFragment?.getOnRecordRelocateRequest()?.removeObserver(onRecordRelocateObserver)
577560
recordMenuFragment?.getOnRecordDeleteRequest()?.removeObserver(onRecordDeleteObserver)
578561
sortOptionsFragment?.getOnSortRequest()?.removeObserver(onSortRequest)
579-
selectionOptionsFragment?.getOnSelectionModifyRequest()?.removeObserver(onSelectionModifyObserver)
562+
selectionMenuFragment?.getOnSelectionModifyRequest()?.removeObserver(onSelectionModifyObserver)
580563
}
581564

582565
override fun onResume() {

0 commit comments

Comments
 (0)