Use the archiveNbr property for generating the banner image

The updateRootColumns endpoint uses the archiveNbr property to generate
the image for the banner. The record object has both the archiveNbr and
the archiveNumber, both having the same value. So we will be using the
archiveNbr for consistency, because it is the correct property from
RecordVO.

Issue: PER-10392

Author: aasandei-vsp

src/app/core/components/profile-edit/profile-edit.component.spec.ts

@@ -122,8 +122,8 @@ describe('ProfileEditComponent', () => {
 			thumbURL500: 'new500',
 			thumbURL1000: 'new1000',
 			thumbURL2000: 'new2000',
-		}) as any;
-		mockRecord.archiveNumber = 999;
+			archiveNbr: 999,
+		});
 		mockFolderPickerService.chooseRecord.and.resolveTo(mockRecord);
 
 		await component.chooseBannerPicture();

src/app/core/components/profile-edit/profile-edit.component.ts

@@ -149,17 +149,17 @@ export class ProfileEditComponent implements OnInit, AfterViewInit {
 	async chooseBannerPicture() {
 		const originalValue = this.publicRoot.thumbArchiveNbr;
 		try {
-			const record = (await this.folderPicker.chooseRecord(
+			const record = await this.folderPicker.chooseRecord(
 				this.account.getPrivateRoot(),
-			)) as any;
+			);
 			const updateFolder = new FolderVO(this.publicRoot);
-			updateFolder.thumbArchiveNbr = record.archiveNumber;
+			updateFolder.thumbArchiveNbr = record.archiveNbr;
 			await this.api.folder.updateRoot(
 				[updateFolder],
 				['thumbArchiveNbr', 'view', 'viewProperty'],
 			);
 			// borrow thumb URLs from record for now, until they can be regenerated
-			this.publicRoot.thumbArchiveNbr = record.archiveNumber;
+			this.publicRoot.thumbArchiveNbr = record.archiveNbr;
 			this.publicRoot.thumbURL200 = record.thumbURL200;
 			this.publicRoot.thumbURL500 = record.thumbURL500;
 			this.publicRoot.thumbURL1000 = record.thumbURL1000;

src/app/shared/services/profile/profile.service.ts

@@ -111,9 +111,9 @@ export class ProfileService {
 		const privateRoot = this.account.getPrivateRoot();
 		try {
 			const currentArchive = this.account.getArchive();
-			const record = (await this.folderPicker.chooseRecord(privateRoot)) as any;
+			const record = await this.folderPicker.chooseRecord(privateRoot);
 			const updateArchive = new ArchiveVO(currentArchive);
-			updateArchive.thumbArchiveNbr = record.archiveNumber;
+			updateArchive.thumbArchiveNbr = record.archiveNbr;
 
 			updateArchive.thumbURL200 = record.thumbURL200;
 			updateArchive.thumbURL500 = record.thumbURL500;