Retrieve all methods using api call

Author: crisnicandrei

src/app/core/components/two-factor-auth/two-factor-auth.component.spec.ts

@@ -171,23 +171,29 @@ describe('TwoFactorAuthComponent', () => {
     expect(codeContainer.length).toBe(0);
   });
 
-  it('should call showError when submitRemoveMethod fails', async () => {
+  it('should retrieve all the methods after a method has been deleted', async () => {
     const { instance } = await shallow.render();
-    messageShown = false;
-
-    spyOn(mockApiService.idpuser, 'disableTwoFactor').and.returnValue(
-      Promise.reject(new Error('API Error')),
-    );
 
+    instance.methods = [
+      { methodId: 'email', method: 'email', value: 'janedoe@example.com' },
+    ];
     instance.selectedMethodToDelete = {
       methodId: 'email',
       method: 'email',
-      value: 'user@example.com',
+      value: 'janedoe@example.com',
     };
-    instance.form.get('code').setValue('123456');
+
+    spyOn(mockApiService.idpuser, 'disableTwoFactor').and.returnValue(
+      Promise.resolve(),
+    );
+    spyOn(mockApiService.idpuser, 'getTwoFactorMethods').and.returnValue(
+      Promise.resolve([
+        { methodId: 'sms', method: 'sms', value: '(123) 456-7890' },
+      ]),
+    );
 
     await instance.submitRemoveMethod();
 
-    expect(messageShown).toBeTrue();
+    expect(mockApiService.idpuser.getTwoFactorMethods).toHaveBeenCalled();
   });
 });

src/app/core/components/two-factor-auth/two-factor-auth.component.ts

@@ -170,15 +170,9 @@ export class TwoFactorAuthComponent implements OnInit {
         this.selectedMethodToDelete.methodId,
         this.form.get('code').value,
       );
-
-      this.methods = this.methods.filter(
-        (m) => m.methodId !== this.selectedMethodToDelete.methodId,
-      );
     } catch (error) {
-      this.message.showError({
-        message: 'Something went wrong while attempting to remove the method',
-      });
     } finally {
+      this.methods = await this.api.idpuser.getTwoFactorMethods();
       this.selectedMethodToDelete = null;
       this.codeSent = false;
       this.method = null;