Skip to content

Commit f28de58

Browse files
committed
Use ionicons web components
We were using embedded SCSS from ionicons instead of their recommended approach which is to use web components + their npm package (though we WERE using their npm package). Issue #893 Move to ionicons web components
1 parent 1d9ba0f commit f28de58

33 files changed

+52
-3620
lines changed

src/app/core/components/folder-picker/folder-picker.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<div class="picker-header">
44
@if (!isRootFolder || selectedRecord) {
55
<div class="picker-back" (click)="onBackClick()">
6-
<i class="ion-md-arrow-dropleft"></i> Back
6+
<ion-icon name="chevron-back"></ion-icon> Back
77
</div>
88
}
99
<div class="picker-folder-name">

src/app/core/components/left-menu/left-menu.component.html

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@
9191
[routerLink]="['/search']"
9292
[class.active]="checkMenuItemActive('/search')"
9393
>
94-
<i class="ion-md-search"></i>
94+
<ion-icon name="search"></ion-icon>
9595
Search
9696
</a>
9797
<a
@@ -216,26 +216,26 @@
216216
[routerLink]="[{ outlets: { dialog: ['invitations'] } }]"
217217
[class.active]="checkMenuItemActive('/invitations')"
218218
>
219-
<i class="ion-md-person-add"></i>
219+
<ion-icon name="person-add"></ion-icon>
220220
Invitations
221221
</a>
222222
<a
223223
class="menu-item hide-desktop"
224224
[routerLink]="[{ outlets: { dialog: ['storage', 'add'] } }]"
225225
>
226-
<i class="ion-md-add-circle"></i>
226+
<ion-icon name="add-circle"></ion-icon>
227227
Add Storage
228228
</a>
229229
<a
230230
class="menu-item hide-desktop"
231231
href="https://desk.zoho.com/portal/permanent/home"
232232
target="_blank"
233233
>
234-
<i class="ion-md-help-circle"></i>
234+
<ion-icon name="help-circle"></ion-icon>
235235
Help
236236
</a>
237237
<a class="menu-item hide-desktop" (click)="logOut()">
238-
<i class="ion-md-exit"></i>
238+
<ion-icon name="exit"></ion-icon>
239239
Log Out
240240
</a>
241241
</div>

src/app/core/components/members-dialog/members-dialog.component.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,12 @@
4141
{{ member.primaryEmail }}
4242
</div>
4343
<div class="member-access">
44-
<i
45-
class="ion-md-information-circle"
44+
<ion-icon
45+
name="information-circle"
4646
[ngbTooltip]="
4747
getTooltipForAccess(member.accessRole) | prTooltip
4848
"
49-
></i>
49+
></ion-icon>
5050
Access: {{ member.accessRole | prConstants }}
5151
</div>
5252
</div>
@@ -110,12 +110,12 @@
110110
{{ member.primaryEmail }}
111111
</div>
112112
<div class="member-access">
113-
<i
114-
class="ion-md-information-circle"
113+
<ion-icon
114+
name="information-circle"
115115
[ngbTooltip]="
116116
getTooltipForAccess(member.accessRole) | prTooltip
117117
"
118-
></i>
118+
></ion-icon>
119119
Access: {{ member.accessRole | prConstants }}
120120
<span>(pending)</span>
121121
</div>

src/app/core/components/nav/nav.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
(click)="rightMenu.createNewFolder()"
5858
[disabled]="!rightMenu.allowedActions.createFolder"
5959
>
60-
<i class="ion-md-folder"></i>New folder
60+
<ion-icon name="folder"></ion-icon>New folder
6161
</button>
6262
}
6363
</div>

src/app/core/core.module.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { NgModule } from '@angular/core';
1+
import { NgModule, CUSTOM_ELEMENTS_SCHEMA } from '@angular/core';
22
import { CommonModule } from '@angular/common';
33
import { CoreRoutingModule } from '@core/core.routes';
44
import { SharedModule } from '@shared/shared.module';
@@ -65,6 +65,7 @@ import { TwoFactorAuthComponent } from './components/two-factor-auth/two-factor-
6565
import { RedeemGiftComponent } from './components/redeem-gift/redeem-gift.component';
6666

6767
@NgModule({
68+
schemas: [CUSTOM_ELEMENTS_SCHEMA],
6869
imports: [
6970
AnnouncementModule,
7071
CommonModule,

src/app/file-browser/components/file-list-item/file-list-item.component.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,11 @@
8787
{{ item.displayName }}
8888
</p>
8989
@if (!showAccess && item.ShareVOs?.length && !isUnlistedShare) {
90-
<i
91-
class="ion-md-people"
90+
<ion-icon
91+
name="people"
9292
@ngIfFadeInAnimation
9393
[ngbTooltip]="'fileList.icons.share' | prTooltip"
94-
></i>
94+
></ion-icon>
9595
}
9696
</div>
9797
<div class="second-row">

src/app/file-browser/components/file-viewer/file-viewer.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
}"
88
>
99
<div class="file-viewer-close">
10-
<a (click)="close()"> <i class="ion-md-arrow-dropleft"></i> Back </a>
10+
<a (click)="close()"> <ion-icon name="chevron-back"></ion-icon> Back </a>
1111
</div>
1212
<div class="thumb-target">
1313
<div

src/app/file-browser/file-browser-components.module.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
import { NgModule, ComponentFactoryResolver } from '@angular/core';
1+
import {
2+
NgModule,
3+
ComponentFactoryResolver,
4+
CUSTOM_ELEMENTS_SCHEMA,
5+
} from '@angular/core';
26
import { CommonModule } from '@angular/common';
37
import { RouterModule } from '@angular/router';
48
import { GoogleMapsModule } from '@angular/google-maps';
@@ -29,6 +33,7 @@ import { SharingDialogComponent } from './components/sharing-dialog/sharing-dial
2933
import { DownloadButtonComponent } from './components/download-button/download-button.component';
3034

3135
@NgModule({
36+
schemas: [CUSTOM_ELEMENTS_SCHEMA],
3237
imports: [
3338
CommonModule,
3439
RouterModule,

src/app/search/components/global-search-bar/global-search-bar.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
(focus)="onInputFocus()"
1010
(keydown)="onInputKeydown($event)"
1111
/>
12-
<i class="ion-md-search"></i>
12+
<ion-icon name="search"></ion-icon>
1313
@if (showResults) {
1414
<div class="search-results">
1515
@if (tagResults?.length) {

src/app/search/components/global-search-bar/global-search-bar.component.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ input {
5757
}
5858
}
5959

60-
i.ion-md-search {
60+
ion-icon[name='search'] {
6161
position: absolute;
6262
left: $input-padding;
6363
opacity: 0.5;

0 commit comments

Comments
 (0)