Remove vendor directory
#897
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 895-package-bootstrap #897 +/- ##
=========================================================
- Coverage 47.87% 47.75% -0.13%
=========================================================
Files 351 350 -1
Lines 11292 11294 +2
Branches 1889 1889
=========================================================
- Hits 5406 5393 -13
- Misses 5694 5711 +17
+ Partials 192 190 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
slifty
force-pushed
the
895-package-bootstrap
branch
from
5697c84 to
dd5550f
Compare
slifty
force-pushed
the
127-remove-vendor
branch
from
b7422b6 to
d2fe15e
Compare
slifty
force-pushed
the
895-package-bootstrap
branch
from
dd5550f to
83f9ced
Compare
This may have been used in the past but currently it isn't. No need to keep a dead (and stale) dependency in our code. Issue #127 Use packages instead of vendored code
In the past few years the JS standard added support for `withResolvers` which obviates the need for a custom implementation of the concept of a Deferred promise. This commit moves to that new standard, adds a polyfill so that we can maintain browser support, and removes our implementation of Deferred. Issue #127 Use packages instead of vendored code
slifty
force-pushed
the
127-remove-vendor
branch
from
d2fe15e to
2322d25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the final steps for removing 3rd party vendor scripts from our code base.
We've (A) removed some unused code and (B) migrated the
deferredpattern to the more modernPromise.withResolversalongside the use of a polyfill for that to maintain compatibility with older browsers.This should be merged AFTER #896
Resolves #127