renaming properties in value item

Author: PeterStaev

README.md

@@ -194,8 +194,8 @@ Then you can set the `items` property of the DropDown to an instance of ValueLis
 ```TypeScript
 let dd = page.getViewById<DropDown>("dd");
 let itemSource = new ValueList<string>([
-    { ValueMember: "FL", DisplayMember:"Florida" }, 
-    { ValueMember: "MI", DisplayMember:"Michigan" }
+    { value: "FL", display: "Florida" }, 
+    { value: "MI", display: "Michigan" }
 ]);
 dd.items = itemSource;
 ```

demo-ng/app/dropdown/dropdown.component.ts

@@ -15,7 +15,7 @@ export class DropDownComponent implements OnInit {
     public ngOnInit() {
         this.items = new ValueList<string>();
         for (let loop = 0; loop < 200; loop++) {
-            this.items.push({ ValueMember: `I${loop}`, DisplayMember: `Item ${loop}`});
+            this.items.push({ value: `I${loop}`, display: `Item ${loop}`});
         }
     }
 

demo/app/main-page.ts

@@ -19,7 +19,7 @@ export function pageLoaded(args: EventData) {
     page.bindingContext = viewModel;
 
     for (let loop = 0; loop < 200; loop++) {
-        items.push({ ValueMember: `I${loop}`, DisplayMember: `Item ${loop}`});
+        items.push({ value: `I${loop}`, display: `Item ${loop}`});
     }
 }
 

drop-down-common.ts

@@ -46,7 +46,7 @@ export abstract class DropDownBase extends View implements DropDownDefinition {
         }
 
         if (this.isValueListIn) {
-            return (items as ValueList<any>).getText(index);
+            return (items as ValueList<any>).getDisplay(index);
         }
 
         const item = this.isItemsSourceIn ? (this.items as ItemsSource).getItem(index) : this.items[index];
@@ -57,7 +57,7 @@ export abstract class DropDownBase extends View implements DropDownDefinition {
 export class ValueList<T> extends ObservableArray<ValueItem<T>> implements ValueListDefinition<T> {
     private _array: Array<ValueItem<T>>;
 
-    public getText(index: number): string {
+    public getDisplay(index: number): string {
         if (types.isNullOrUndefined(index)) {
             return null;
         }
@@ -66,15 +66,15 @@ export class ValueList<T> extends ObservableArray<ValueItem<T>> implements Value
             return "";
         }
 
-        return this._array[index].DisplayMember;
+        return this._array[index].display;
     }
 
     public getValue(index: number): T {
         if (types.isNullOrUndefined(index) || index < 0 || index >= this.length) {
             return null;
         }
 
-        return this._array[index].ValueMember;
+        return this._array[index].value;
     }
 
     public getIndex(value: T): number {
@@ -124,10 +124,10 @@ export const itemsProperty = new Property<DropDownBase, any[] | ItemsSource>({
     name: "items",
     valueChanged: (target, oldValue, newValue) => {
         const getItem = newValue && (newValue as ItemsSource).getItem;
-        const getText = newValue && (newValue as ValueList<any>).getText;
+        const getDisplay = newValue && (newValue as ValueList<any>).getDisplay;
 
         target.isItemsSourceIn = typeof getItem === "function";
-        target.isValueListIn = typeof getText === "function";
+        target.isValueListIn = typeof getDisplay === "function";
     }
 });
 itemsProperty.register(DropDownBase);

drop-down.d.ts

@@ -24,8 +24,8 @@ export interface SelectedIndexChangedEventData extends EventData {
 }
 
 export interface ValueItem<T> {
-    ValueMember: T;
-    DisplayMember: string;
+    value: T;
+    display: string;
 }
 
 export class DropDown extends View {
@@ -52,7 +52,7 @@ export class DropDown extends View {
 }
 
 export class ValueList<T> extends ObservableArray<ValueItem<T>> {
-    public getText(index: number): string;
+    public getDisplay(index: number): string;
     public getValue(index: number): T;
     public getIndex(value: T): number;   
 }

drop-down.ios.ts

@@ -450,6 +450,7 @@ class TNSDropDownLabel extends TNSLabel {
 
         if (!this._hasText) {
             this.text = value;
+            this._owner.get()._setTextAttributes();
         }
     }
 

gruntfile.js

@@ -1,16 +1,11 @@
 module.exports = function (grunt) {
     var localConfig = {
-        typeScriptSrc: [
-            "**/*.ts",
-            "!node_modules/**/*.*",
-            "!demo/**/*.*",
-            "!bin/**/*.*"
-        ],
         typeScriptDeclarations: [
             "**/*.d.ts",
             "!references.d.ts",
             "!node_modules/**/*.*",
             "!demo/**/*.*",
+            "!demo-ng/**/*.*",
             "!bin/**/*.*"
         ],
         outDir: "bin/dist/"

package.json

@@ -1,6 +1,6 @@
 {
   "name": "nativescript-drop-down",
-  "version": "3.0.0-rc.2",
+  "version": "3.0.0-rc.3",
   "description": "A NativeScript DropDown widget.",
   "main": "drop-down",
   "typings": "drop-down.d.ts",

tsconfig.json

@@ -22,6 +22,7 @@
     "exclude": [
         "node_modules", 
         "demo", 
+        "demo-ng", 
         "bin"
     ]
 }