lint fixes

Author: PeterStaev

.vscode/tasks.json

@@ -11,10 +11,7 @@
 			"taskName": "build",
 			"args": [], 
 			"isBuildCommand": true, 
-			"problemMatcher": ["$tsc", {
-                "base": "$tslint5",
-                "fileLocation": "relative"
-            }]
+			"problemMatcher": ["$tsc", "$tslint4"]
 		}	
 	]
 }

grid-view.android.ts

@@ -159,6 +159,7 @@ export class GridView extends GridViewBase {
             bottom: nativeView.getPaddingBottom(),
             left: nativeView.getPaddingLeft()
         };
+        // tslint:disable-next-line:prefer-object-spread
         const newValue = Object.assign(padding, newPadding);
         nativeView.setPadding(newValue.left, newValue.top, newValue.right, newValue.bottom);
     }
@@ -210,12 +211,13 @@ class GridViewCellHolder extends android.support.v7.widget.RecyclerView.ViewHold
 
     public onClick(v: android.view.View) {
         const gridView = this.gridView.get();
-        gridView.notify({
+
+        gridView.notify<GridItemEventData>({
             eventName: GridViewBase.itemTapEvent,
             object: gridView,
             index: this.getAdapterPosition(),
             view: this.view
-        } as GridItemEventData);            
+        });            
     }
 
 }
@@ -250,12 +252,12 @@ class GridViewAdapter extends android.support.v7.widget.RecyclerView.Adapter {
     public onBindViewHolder(vh: GridViewCellHolder, index: number) {
         const owner = this.owner.get();
 
-        owner.notify({
+        owner.notify<GridItemEventData>({
             eventName: GridViewBase.itemLoadingEvent,
             object: owner,
             index,
             view: vh.view
-        } as GridItemEventData);
+        });
 
         vh.view.height = utils.layout.toDeviceIndependentPixels(owner._effectiveRowHeight);
 

grid-view.ios.ts

@@ -164,12 +164,12 @@ export class GridView extends GridViewBase {
                 view = this._getItemTemplateContent();
             }
 
-            this.notify({
+            this.notify<GridItemEventData>({
                 eventName: GridViewBase.itemLoadingEvent,
                 object: this,
                 index: indexPath.row,
                 view
-            } as GridItemEventData);
+            });
 
             // If cell is reused it have old content - remove it first.
             if (!cell.view) {
@@ -219,6 +219,7 @@ export class GridView extends GridViewBase {
             bottom: this._layout.sectionInset.bottom,
             left: this._layout.sectionInset.left
         };
+        // tslint:disable-next-line:prefer-object-spread
         const newValue = Object.assign(padding, newPadding);
         this._layout.sectionInset =
             UIEdgeInsetsFromString(`{${newValue.top},${newValue.left},${newValue.bottom},${newValue.right}}`);
@@ -288,10 +289,10 @@ class UICollectionViewDelegateImpl extends NSObject implements UICollectionViewD
         const owner = this._owner.get();
 
         if (indexPath.row === owner.items.length - 1) {
-            owner.notify({
+            owner.notify<EventData>({
                 eventName: GridViewBase.loadMoreItemsEvent,
                 object: owner
-            } as EventData);
+            });
         }
 
         if (cell.preservesSuperviewLayoutMargins) {
@@ -307,12 +308,12 @@ class UICollectionViewDelegateImpl extends NSObject implements UICollectionViewD
         const cell = collectionView.cellForItemAtIndexPath(indexPath);
         const owner = this._owner.get();
 
-        owner.notify({
+        owner.notify<GridItemEventData>({
             eventName: GridViewBase.itemTapEvent,
             object: owner,
             index: indexPath.row,
             view: (cell as GridViewCell).view
-        } as GridItemEventData);
+        });
 
         cell.highlighted = false;
 

package.json

@@ -37,8 +37,8 @@
   },
 
   "devDependencies": {
-    "typescript": "~2.2.0",
-    "tslint": "^5.1.0",
+    "typescript": "2.2.2",
+    "tslint": "4.4.2",
     "tns-core-modules": "3.1.0",
     "tns-platform-declarations": "3.1.0",
 

tsconfig.json

@@ -6,6 +6,7 @@
         "removeComments": true,
         "declaration": false,
         "experimentalDecorators": true,
+        "noUnusedLocals": true,
         "target": "es5",
         "module": "commonjs",
         "outDir": "bin/dist",

tslint.json

@@ -26,7 +26,6 @@
       true,
       {"named-imports-order": "lowercase-last"}
     ],
-    "no-unused-variable": [true],
     "no-bitwise": false
   }
 }