Skip to content

Commit 9d4daff

Browse files
committed
Minor documentation additions
1 parent ccc6ac5 commit 9d4daff

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,8 @@ https://www.sparkfun.com/datasheets/GPS/NMEA%20Reference%20Manual1.pdf
138138

139139
https://www.nmea.org/Assets/20190303%20nmea%200183%20talker%20identifier%20mnemonics.pdf
140140

141+
https://www.unavco.org/help/glossary/glossary.html
142+
141143

142144
## Support
143145
If you find this tool useful, please consider supporting development of this tool and other tools like it. You can do so using the `Sponsor` button at the top of the [GitHub page](https://github.com/Petrichor-Labs/nmea_data_convert).

nmea_data_convert.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,7 @@ def sentences_to_dataframes(sentence_sets):
268268

269269
# Add columns for data fields missing from class
270270
# TODO: Fork pynmea2 module to correct
271+
# Issure reported here: https://github.com/Knio/pynmea2/issues/118
271272
if sentence_sets[set_idx][0].sentence.sentence_type == 'RMC':
272273
columns.append('mode')
273274

@@ -390,7 +391,8 @@ def __str__(self):
390391

391392

392393
class MergedSentence_GSV:
393-
394+
#TODO: Have MergedSentence_GSV inherit from DateTimeStampedSentence ?
395+
394396
def __init__(self, merge_group):
395397

396398
self.cycle_id = merge_group[0].cycle_id

0 commit comments

Comments
 (0)