Fix bug in IdentityMask calculation (#99)

Pharap · web-flow · commit 79ef8398f324 · 2022-09-25T10:37:25.000+01:00
The bit width of the type was not being sufficiently increased, which was leading to dropped bits, which in turn caused problems with floating point conversion and possibly other problems.
diff --git a/src/FixedPoints/Details.h b/src/FixedPoints/Details.h
@@ -126,7 +126,7 @@ namespace FIXED_POINTS_DETAILS
 	struct IdentityMask
 	{
 		IdentityMask() = delete;
-		static constexpr LeastUInt<Bits> Value = 1 | (IdentityMask<Bits - 1>::Value << 1);
+		static constexpr LeastUInt<Bits> Value = 1 | (static_cast<LeastUInt<Bits>>(IdentityMask<Bits - 1>::Value) << 1);
 	};
 
 	template<>

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ namespace FIXED_POINTS_DETAILS`
`126`	`126`	`struct IdentityMask`
`127`	`127`	`{`
`128`	`128`	`IdentityMask() = delete;`
`129`		`- static constexpr LeastUInt<Bits> Value = 1 \| (IdentityMask<Bits - 1>::Value << 1);`
	`129`	`+ static constexpr LeastUInt<Bits> Value = 1 \| (static_cast<LeastUInt<Bits>>(IdentityMask<Bits - 1>::Value) << 1);`
`130`	`130`	`};`
`131`	`131`
`132`	`132`	`template<>`