Merge pull request #26 from Phauthentic/new-rules

Adding Property related Rules

Author: floriankraemer

README.md

@@ -25,12 +25,16 @@ See individual rule documentation for detailed configuration examples. A [full c
 - [Class Must Be Readonly Rule](docs/rules/Class-Must-Be-Readonly-Rule.md)
 - [Class Must Have Specification Docblock Rule](docs/rules/Class-Must-Have-Specification-Docblock-Rule.md)
 - [Classname Must Match Pattern Rule](docs/rules/Classname-Must-Match-Pattern-Rule.md)
-- [Dependency Constraints Rule](docs/rules/Dependency-Constraints-Rule.md)
+- [Dependency Constraints Rule](docs/rules/Dependency-Constraints-Rule.md) *(deprecated, use Forbidden Dependencies Rule)*
+- [Forbidden Accessors Rule](docs/rules/Forbidden-Accessors-Rule.md)
+- [Forbidden Dependencies Rule](docs/rules/Forbidden-Dependencies-Rule.md)
 - [Forbidden Namespaces Rule](docs/rules/Forbidden-Namespaces-Rule.md)
+- [Forbidden Static Methods Rule](docs/rules/Forbidden-Static-Methods-Rule.md)
 - [Method Must Return Type Rule](docs/rules/Method-Must-Return-Type-Rule.md)
 - [Method Signature Must Match Rule](docs/rules/Method-Signature-Must-Match-Rule.md)
 - [Methods Returning Bool Must Follow Naming Convention Rule](docs/rules/Methods-Returning-Bool-Must-Follow-Naming-Convention-Rule.md)
 - [Modular Architecture Rule](docs/rules/Modular-Architecture-Rule.md)
+- [Property Must Match Rule](docs/rules/Property-Must-Match-Rule.md)
 
 ### Clean Code Rules
 

composer.json

@@ -3,7 +3,7 @@
     "type": "library",
     "require-dev": {
         "phpstan/phpstan": "^2.1",
-        "phpunit/phpunit": "^12.0",
+        "phpunit/phpunit": "^12.5.8",
         "squizlabs/php_codesniffer": "^3.12"
     },
     "autoload": {

composer.lock

@@ -0,0 +1,30 @@
+<?php
+
+namespace App\BoolNaming;
+
+class EdgeCaseMethodBoolClass
+{
+    public function __construct()
+    {
+    }
+
+    public function __toString(): string
+    {
+        return 'test';
+    }
+
+    public function noReturnType()
+    {
+        return true;
+    }
+
+    public function isValid(): bool
+    {
+        return true;
+    }
+
+    public function check(): bool
+    {
+        return true;
+    }
+}

data/BoolNaming/EdgeCaseMethodBoolClass.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Forbidden;
+
+class ChildService extends ForbiddenService
+{
+    public function callParent(): string
+    {
+        return parent::create();
+    }
+}

data/Forbidden/ChildService.php

@@ -0,0 +1,23 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Forbidden;
+
+class ForbiddenService
+{
+    public static function create(): string
+    {
+        return 'created';
+    }
+
+    public function callSelf(): string
+    {
+        return self::create();
+    }
+
+    public function callStatic(): string
+    {
+        return static::create();
+    }
+}

data/Forbidden/ForbiddenService.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace App\Domain;
+
+$entity = new class {
+    public function getName(): string
+    {
+        return 'name';
+    }
+
+    public function setName(string $name): void
+    {
+    }
+};

data/ForbiddenAccessors/AnonymousClassWithAccessors.php

@@ -0,0 +1,65 @@
+<?php
+
+namespace App\Domain;
+
+class UserEntity
+{
+    private string $name;
+    private int $age;
+    private bool $active;
+
+    public function getName(): string
+    {
+        return $this->name;
+    }
+
+    public function setName(string $name): void
+    {
+        $this->name = $name;
+    }
+
+    public function getAge(): int
+    {
+        return $this->age;
+    }
+
+    public function setAge(int $age): void
+    {
+        $this->age = $age;
+    }
+
+    protected function getActive(): bool
+    {
+        return $this->active;
+    }
+
+    protected function setActive(bool $active): void
+    {
+        $this->active = $active;
+    }
+
+    private function getPrivateValue(): string
+    {
+        return 'private';
+    }
+
+    private function setPrivateValue(string $value): void
+    {
+        // This should not trigger an error (private)
+    }
+
+    public function doSomething(): void
+    {
+        // Regular method, should not trigger
+    }
+
+    public function get(): void
+    {
+        // Should not trigger - no uppercase letter after 'get'
+    }
+
+    public function set(): void
+    {
+        // Should not trigger - no uppercase letter after 'set'
+    }
+}

data/ForbiddenAccessors/EntityWithAccessors.php

@@ -0,0 +1,18 @@
+<?php
+
+namespace App\Service;
+
+class ServiceWithAccessors
+{
+    private string $config;
+
+    public function getConfig(): string
+    {
+        return $this->config;
+    }
+
+    public function setConfig(string $config): void
+    {
+        $this->config = $config;
+    }
+}

data/ForbiddenAccessors/ServiceWithAccessors.php

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Service;
+
+class DynamicCallService
+{
+    public function dynamicMethod(): void
+    {
+        $method = 'calculate';
+        \App\Utils\StaticHelper::$method();
+    }
+
+    public function dynamicClass(): void
+    {
+        $class = \App\Utils\StaticHelper::class;
+        $class::calculate();
+    }
+}