Migrate away from deprecated strong mode analysis options (#832)

* Migrate away from deprecated strong-mode analysis options
---------

Co-authored-by: Parker Lougheed <[email protected]>

Author: Taym95

analysis_options.yaml

@@ -1,9 +1,10 @@
 include: package:flutter_lints/flutter.yaml
 
 analyzer:
-  strong-mode:
-    implicit-casts: false
-    implicit-dynamic: false
+  language:
+    # strict-casts: true -- DISABLED: was introduced in Dart 2.16
+    strict-inference: true
+    strict-raw-types: true
   exclude:
     - "bin/cache/**"
     - "**/*.freezed.dart"
@@ -27,8 +28,7 @@ linter:
     - empty_statements
     - hash_and_equals
     - invariant_booleans
-    - iterable_contains_unrelated_type
-    - list_remove_unrelated_type
+    - collection_methods_unrelated_type
     - literal_only_boolean_expressions
     - no_adjacent_strings_in_list
     - no_duplicate_case_values

example/lib/src/ble/ble_device_connector.dart

@@ -6,7 +6,7 @@ import 'package:flutter_reactive_ble_example/src/ble/reactive_state.dart';
 class BleDeviceConnector extends ReactiveState<ConnectionStateUpdate> {
   BleDeviceConnector({
     required FlutterReactiveBle ble,
-    required Function(String message) logMessage,
+    required void Function(String message) logMessage,
   })  : _ble = ble,
         _logMessage = logMessage;
 

example/lib/src/ble/ble_scanner.dart

@@ -7,7 +7,7 @@ import 'package:meta/meta.dart';
 class BleScanner implements ReactiveState<BleScannerState> {
   BleScanner({
     required FlutterReactiveBle ble,
-    required Function(String message) logMessage,
+    required void Function(String message) logMessage,
   })  : _ble = ble,
         _logMessage = logMessage;
 
@@ -59,7 +59,7 @@ class BleScanner implements ReactiveState<BleScannerState> {
     await _stateStreamController.close();
   }
 
-  StreamSubscription? _subscription;
+  StreamSubscription<DiscoveredDevice>? _subscription;
 }
 
 @immutable

example/pubspec.lock

@@ -207,7 +207,7 @@ packages:
     source: sdk
     version: "0.0.0"
   flutter_lints:
-    dependency: "direct main"
+    dependency: "direct dev"
     description:
       name: flutter_lints
       sha256: b543301ad291598523947dc534aaddc5aaad597b709d2426d3a0e0d44c5cb493
@@ -591,4 +591,4 @@ packages:
     version: "3.1.1"
 sdks:
   dart: ">=3.2.0-194.0.dev <4.0.0"
-  flutter: ">=1.16.0"
+  flutter: ">=2.0.0"

example/pubspec.yaml

@@ -5,12 +5,11 @@ publish_to: 'none'
 
 environment:
   sdk: '>=2.17.0 <3.0.0'
-  flutter: ">=1.10.0"
+  flutter: ">=2.0.0"
 
 dependencies:
   flutter:
     sdk: flutter
-  flutter_lints: ^1.0.4
   flutter_reactive_ble: ^5.2.0
   functional_data: ^1.0.0
   intl: ^0.17.0
@@ -20,6 +19,7 @@ dependencies:
 dev_dependencies:
   build_runner: ^2.3.3
   dependency_validator: ^3.1.0
+  flutter_lints: ^1.0.4
   flutter_test:
     sdk: flutter
   functional_data_generator: ^1.1.2

packages/flutter_reactive_ble/lib/src/rx_ext/serial_disposable.dart

@@ -41,10 +41,10 @@ class _SerialAlreadyDisposed extends Error {
 }
 
 /// A [SerialDisposable] that contains an underlying stream subscription.
-class StreamSubscriptionSerialDisposable
-    extends SerialDisposable<StreamSubscription> {
+class StreamSubscriptionSerialDisposable<T>
+    extends SerialDisposable<StreamSubscription<T>> {
   StreamSubscriptionSerialDisposable()
-      : super((StreamSubscription subscription) async {
+      : super((StreamSubscription<T> subscription) async {
           await subscription.cancel();
           return const Unit();
         });

packages/reactive_ble_mobile/pubspec.lock

@@ -198,6 +198,14 @@ packages:
     description: flutter
     source: sdk
     version: "0.0.0"
+  flutter_lints:
+    dependency: "direct dev"
+    description:
+      name: flutter_lints
+      sha256: b543301ad291598523947dc534aaddc5aaad597b709d2426d3a0e0d44c5cb493
+      url: "https://pub.dev"
+    source: hosted
+    version: "1.0.4"
   flutter_test:
     dependency: "direct dev"
     description: flutter
@@ -275,6 +283,14 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "4.8.1"
+  lints:
+    dependency: transitive
+    description:
+      name: lints
+      sha256: a2c3d198cb5ea2e179926622d433331d8b58374ab8f29cdda6e863bd62fd369c
+      url: "https://pub.dev"
+    source: hosted
+    version: "1.0.1"
   logging:
     dependency: transitive
     description:

packages/reactive_ble_mobile/pubspec.yaml

@@ -15,6 +15,7 @@ dependencies:
 
 dev_dependencies:
   build_runner: ^2.3.3
+  flutter_lints: ^1.0.4
   flutter_test:
     sdk: flutter
   mockito: ^5.0.14