[Minor] Turretless vehicles with Voxel=no use FireUp (#1684)

`Voxel=no` turretless vehicles now support the use of `FireUp`.
`FireUp.ResetInRetarget` determines whether a vehicle's FireUp count is
reset when its target changes. Defaults to `yes`. forced to be `yes`
when there is no target.

In `artmd.ini`:
```ini
[SOMEVEHICLE]
FireUp=                     ; integer
FireUp.ResetInRetarget=     ; boolean
```
---------
`Voxel=no`的无炮塔载具支持使用`FireUp`。
`FireUp.ResetInRetarget`决定目标改变时是否重置车辆的FireUp计数。默认为`yes`。没有目标时强制为`yes`。

In `artmd.ini`:
```ini
[SOMEVEHICLE]
FireUp=                     ; integer
FireUp.ResetInRetarget=     ; boolean
```

Author: Fly-Star-him

CREDITS.md

@@ -368,6 +368,7 @@ This page lists all the individual contributions to the project by their author.
   - Fixed an issue where a portion of Ares's trigger event 75/77 was determined unsuccessfully
   - Second weapon with `ElectricAssault=yes` will not unconditionally attack your building with `Overpowerable=yes`
   - Fixed some units of Ares crashing after deployment conversion
+  - Turretless vehicles with `Voxel=no` support use `FireUp` like infantry.
 - **NetsuNegi**:
   - Forbidding parallel AI queues by type
   - Jumpjet crash speed fix when crashing onto building

Phobos.vcxproj

@@ -18,6 +18,7 @@
     </ProjectConfiguration>
   </ItemGroup>
   <ItemGroup>
+    <ClCompile Include="src\Ext\Unit\Hooks.Firing.cpp" />
     <ClCompile Include="src\New\Type\Affiliated\CreateUnitTypeClass.cpp" />
     <ClCompile Include="src\Blowfish\blowfish.cpp" />
     <ClCompile Include="src\Blowfish\Hooks.Blowfish.cpp" />

docs/New-or-Enhanced-Logics.md

@@ -1849,6 +1849,18 @@ JumpjetTilt.SidewaysRotationFactor=1.0  ; floating point value
 JumpjetTilt.SidewaysSpeedFactor=1.0     ; floating point value
 ```
 
+### Turretless Shape Vehicle FireUp
+
+- `Voxel=no` turretless vehicles now support the use of `FireUp`.
+ - `FireUp.ResetInRetarget` determines whether a vehicle's FireUp count is reset when its target changes. Defaults to `yes`. forced to be `yes` when there is no target.
+
+In `artmd.ini`:
+```ini
+[SOMEVEHICLE]
+FireUp=                         ; integer
+FireUp.ResetInRetarget=true     ; boolean
+```
+
 ## Warheads
 
 ```{hint}
@@ -2214,7 +2226,7 @@ AreaFire.Target=base ; AreaFire Target Enumeration (base|self|random)
 - `Burst.Delays` allows specifying weapon-specific burst shot delays. Takes precedence over the old `BurstDelayX` logic available on VehicleTypes, functions with Infantry & BuildingType weapons (AircraftTypes are not supported due to their weapon firing system being completely different) and allows every shot of `Burst` to have a separate delay instead of only first four shots.
   - If no delay is defined for a shot, it falls back to last delay value defined (f.ex `Burst=3` and `Burst.Delays=10` would use 10 as delay for all shots).
   - Using `-1` as delay reverts back to old logic (`BurstDelay0-3` for VehicleTypes if available or random value between 3-5 otherwise) for that shot.
-- `Burst.FireWithinSequence` is only used if the weapon is fired by InfantryTypes, and setting it to true allows infantry to fire multiple `Burst` shots within same firing sequence.
+- `Burst.FireWithinSequence` is only used if the weapon is fired by InfantryType or `Voxel=no` turretless VehicleType, and setting it to true allows infantry/vehicle to fire multiple `Burst` shots within same firing sequence.
   - First shot is always fired at sequence frame determined by firing frame controls on InfantryType image (`FireUp` et al).
   - Following shots come at intervals determined by `Burst.Delays` (with minimum delay of 1 frame) or random delay between 3 to 5 frames if not defined. Note that if next shot would be fired at a frame that is beyond the firing sequence's length, burst shot count is reset and weapon starts reloading.
   - Burst shot counter is not immediately reset if firing is ceased mid-sequence after at least one shot, but the frame at which each burst shot is fired will not be influenced by this (in other words, resuming firing afterward without weapon reload taking place would restart firing sequence but no firing will take place until the frame at which next burst shot should be fired is hit).

docs/Whats-New.md

@@ -388,6 +388,7 @@ New:
 - [Power plant damage factor](Fixed-or-Improved-Logics#power-plant-damage-factor) (by Otamaa and Ollerus)
 - Customize whether `Crater=yes` animation would destroy tiberium (by TaranDahl)
 - Weapon target filtering by health percentage (by NetsuNegi)
+- Turretless vehicles with `Voxel=no` support use `FireUp` like infantry (by FlyStar)
 
 Vanilla fixes:
 - Fixed sidebar not updating queued unit numbers when adding or removing units when the production is on hold (by CrimRecya)

docs/locale/zh_CN/LC_MESSAGES/New-or-Enhanced-Logics.po

@@ -7843,7 +7843,7 @@ msgid ""
 "InfantryTypes, and setting it to true allows infantry to fire multiple "
 "`Burst` shots within same firing sequence."
 msgstr ""
-"`Burst.FireWithinSequence` 仅在步兵发射武器时使用，将其设为 true 以允许步兵在同一射击序列内射出多发 "
+"`Burst.FireWithinSequence` 仅在步兵或`Voxel=no`的无炮塔载具发射武器时使用，将其设为 true 以允许步兵/载具在同一射击序列内射出多发 "
 "`Burst`。"
 
 #: ../../New-or-Enhanced-Logics.md:2204

src/Ext/Techno/Body.cpp

@@ -620,6 +620,7 @@ void TechnoExt::ExtData::Serialize(T& Stm)
 		.Process(this->LastSensorsMapCoords)
 		.Process(this->TiberiumEater_Timer)
 		.Process(this->AirstrikeTargetingMe)
+		.Process(this->FiringAnimationTimer)
 		;
 }
 

src/Ext/Techno/Body.h

@@ -71,6 +71,8 @@ class TechnoExt
 
 		AirstrikeClass* AirstrikeTargetingMe;
 
+		CDTimerClass FiringAnimationTimer;
+
 		ExtData(TechnoClass* OwnerObject) : Extension<TechnoClass>(OwnerObject)
 			, TypeExtData { nullptr }
 			, Shield {}
@@ -115,6 +117,7 @@ class TechnoExt
 			, LastSensorsMapCoords { CellStruct::Empty }
 			, TiberiumEater_Timer {}
 			, AirstrikeTargetingMe { nullptr }
+			, FiringAnimationTimer {}
 		{ }
 
 		void OnEarlyUpdate();

src/Ext/Techno/Hooks.cpp

@@ -929,3 +929,29 @@ DEFINE_HOOK(0x5F4032, ObjectClass_FallingDown_ToDead, 0x6)
 }
 
 #pragma endregion
+
+DEFINE_HOOK(0x6FCF8C, TechnoClass_SetTarget_After, 0x6)
+{
+	GET(TechnoClass*, pThis, ESI);
+
+	if (const auto pUnit = abstract_cast<UnitClass*, true>(pThis))
+	{
+		const auto pUnitType = pUnit->Type;
+
+		if (!pUnitType->Turret && !pUnitType->Voxel)
+		{
+			const auto pTarget = pThis->Target;
+			const auto pExt = TechnoExt::ExtMap.Find(pThis);
+			const auto pTypeExt = pExt->TypeExtData;
+
+			if (!pTarget || pTypeExt->FireUp < 0 || pTypeExt->FireUp_ResetInRetarget
+				|| !pThis->IsCloseEnough(pTarget, pThis->SelectWeapon(pTarget)))
+			{
+				pUnit->CurrentFiringFrame = -1;
+				pExt->FiringAnimationTimer.Stop();
+			}
+		}
+	}
+
+	return 0;
+}

src/Ext/TechnoType/Body.cpp

@@ -874,6 +874,26 @@ void TechnoTypeExt::ExtData::LoadFromINIFile(CCINIClass* const pINI)
 
 	if (GeneralUtils::IsValidString(pThis->PaletteFile) && !pThis->Palette)
 		Debug::Log("[Developer warning] [%s] has Palette=%s set but no palette file was loaded (missing file or wrong filename). Missing palettes cause issues with lighting recalculations.\n", pArtSection, pThis->PaletteFile);
+
+	this->LoadFromINIByWhatAmI(exArtINI, pArtSection);
+}
+
+void TechnoTypeExt::ExtData::LoadFromINIByWhatAmI(INI_EX& exArtINI, const char* pArtSection)
+{
+	AbstractType abs = this->OwnerObject()->WhatAmI();
+
+	switch (abs)
+	{
+	case AbstractType::UnitType:
+	{
+		this->FireUp.Read(exArtINI, pArtSection, "FireUp");
+		this->FireUp_ResetInRetarget.Read(exArtINI, pArtSection, "FireUp.ResetInRetarget");
+		//this->SecondaryFire.Read(exArtINI, pArtSection, "SecondaryFire");
+		break;
+	}
+	default:
+		break;
+	}
 }
 
 template <typename T>
@@ -1199,6 +1219,10 @@ void TechnoTypeExt::ExtData::Serialize(T& Stm)
 		.Process(this->FallingDownDamage_Water)
 
 		.Process(this->FiringForceScatter)
+    
+		.Process(this->FireUp)
+		.Process(this->FireUp_ResetInRetarget)
+		//.Process(this->SecondaryFire)
 		;
 }
 void TechnoTypeExt::ExtData::LoadFromStream(PhobosStreamReader& Stm)

src/Ext/TechnoType/Body.h

@@ -364,6 +364,10 @@ class TechnoTypeExt
 
 		Valueable<bool> FiringForceScatter;
 
+		Valueable<int> FireUp;
+		Valueable<bool> FireUp_ResetInRetarget;
+		//Nullable<int> SecondaryFire;
+
 		ExtData(TechnoTypeClass* OwnerObject) : Extension<TechnoTypeClass>(OwnerObject)
 			, HealthBar_Hide { false }
 			, UIDescription {}
@@ -678,6 +682,10 @@ class TechnoTypeExt
 			, FallingDownDamage_Water {}
 
 			, FiringForceScatter { true }
+
+			, FireUp { -1 }
+			, FireUp_ResetInRetarget { true }
+			//, SecondaryFire {}
 		{ }
 
 		virtual ~ExtData() = default;
@@ -690,6 +698,7 @@ class TechnoTypeExt
 		virtual void SaveToStream(PhobosStreamWriter& Stm) override;
 
 		void ApplyTurretOffset(Matrix3D* mtx, double factor = 1.0);
+		void LoadFromINIByWhatAmI(INI_EX& exArtINI, const char* pArtSection);
 
 		int SelectForceWeapon(TechnoClass* pThis, AbstractClass* pTarget);