Fix fake thiscall

ZivDero · ZivDero · commit 2f53fb5684c9 · 2025-06-09T22:20:00.000+03:00
diff --git a/YRpp b/YRpp
@@ -1 +1 @@
-Subproject commit 0ea46afafa2d349f3459216b1a885f4538e87dee
+Subproject commit 9946953417d8a6de27b88836a5b16086cd96a348
diff --git a/src/Ext/Building/Hooks.cpp b/src/Ext/Building/Hooks.cpp
@@ -172,11 +172,10 @@ DEFINE_HOOK(0x44CEEC, BuildingClass_Mission_Missile_EMPulseSelectWeapon, 0x6)
 	return SkipGameCode;
 }
 
-CoordStruct* __fastcall BuildingClass_GetFireCoords_Wrapper(BuildingClass* pThis, CoordStruct* buffer, CoordStruct* pCrd, int weaponIndex)
+CoordStruct* __fastcall BuildingClass_GetFireCoords_Wrapper(BuildingClass* pThis, void* _, CoordStruct* pCrd, int weaponIndex)
 {
-	auto coords = MapClass::Instance.GetCellAt(pThis->Owner->EMPTarget)->GetCellCoords();
-	*buffer = pThis->GetFLH(EMPulseCannonTemp::weaponIndex, coords);
-	return buffer;
+	*pCrd = pThis->GetFLH(EMPulseCannonTemp::weaponIndex);
+	return pCrd;
 }
 
 DEFINE_FUNCTION_JUMP(CALL6, 0x44D1F9, BuildingClass_GetFireCoords_Wrapper);

Original file line number	Diff line number	Diff line change
`@@ -172,11 +172,10 @@ DEFINE_HOOK(0x44CEEC, BuildingClass_Mission_Missile_EMPulseSelectWeapon, 0x6)`
`172`	`172`	`return SkipGameCode;`
`173`	`173`	`}`
`174`	`174`
`175`		`-CoordStruct* __fastcall BuildingClass_GetFireCoords_Wrapper(BuildingClass* pThis, CoordStruct* buffer, CoordStruct* pCrd, int weaponIndex)`
	`175`	`+CoordStruct* __fastcall BuildingClass_GetFireCoords_Wrapper(BuildingClass* pThis, void* _, CoordStruct* pCrd, int weaponIndex)`
`176`	`176`	`{`
`177`		`- auto coords = MapClass::Instance.GetCellAt(pThis->Owner->EMPTarget)->GetCellCoords();`
`178`		`- *buffer = pThis->GetFLH(EMPulseCannonTemp::weaponIndex, coords);`
`179`		`- return buffer;`
	`177`	`+ *pCrd = pThis->GetFLH(EMPulseCannonTemp::weaponIndex);`
	`178`	`+ return pCrd;`
`180`	`179`	`}`
`181`	`180`
`182`	`181`	`DEFINE_FUNCTION_JUMP(CALL6, 0x44D1F9, BuildingClass_GetFireCoords_Wrapper);`