Skip to content

Commit 71622be

Browse files
committed
Fix and add comment dates
1 parent 323648f commit 71622be

File tree

8 files changed

+18
-18
lines changed

8 files changed

+18
-18
lines changed

src/Ext/Aircraft/Hooks.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -692,7 +692,7 @@ DEFINE_HOOK(0x418CD1, AircraftClass_Mission_Attack_ContinueFlyToDestination, 0x6
692692
return Return;
693693
}
694694

695-
// 10.6.2025 - Starkku: This is a bandaid fix to AI scripting problem that causes more issues than it solves so I have disabled it.
695+
// Jun 10, 2025 - Starkku: This is a bandaid fix to AI scripting problem that causes more issues than it solves so I have disabled it.
696696
/*
697697
// Idle: clear the target if no ammo
698698
DEFINE_HOOK(0x414D4D, AircraftClass_Update_ClearTargetIfNoAmmo, 0x6)

src/Ext/SWType/FireSuperWeapon.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,10 @@ inline void LimboCreate(BuildingTypeClass* pType, HouseClass* pOwner, int ID)
9393
pBuilding->IsAlive = true;
9494
pBuilding->IsOnMap = true;
9595

96-
// For reasons beyond my comprehension, the discovery logic is checked for certain logics like power drain/output in campaign only.
96+
// Jun 3, 2023 - Starkku: For reasons beyond my comprehension, the discovery logic is checked for certain logics like power drain/output in campaign only.
9797
// Normally on unlimbo the buildings are revealed to current player if unshrouded or if game is a campaign and to non-player houses always.
9898
// Because of the unique nature of LimboDelivered buildings, this has been adjusted to always reveal to the current player in singleplayer
99-
// and to the owner of the building regardless, removing the shroud check from the equation since they don't physically exist - Starkku
99+
// and to the owner of the building regardless, removing the shroud check from the equation since they don't physically exist
100100
if (SessionClass::IsCampaign())
101101
pBuilding->DiscoveredBy(HouseClass::CurrentPlayer);
102102

src/Ext/Techno/Hooks.Airstrike.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ DEFINE_HOOK(0x70E92F, TechnoClass_UpdateAirstrikeTint, 0x5)
198198
return TechnoExt::ExtMap.Find(pThis)->AirstrikeTargetingMe ? ContinueIn : Skip;
199199
}
200200

201-
// 9.6.2025 - Starkku: Moved to BuildingClass_AI hook in Buildings/Hooks.cpp for optimization's sake.
201+
// Jun 9, 2025 - Starkku: Moved to BuildingClass_AI hook in Buildings/Hooks.cpp for optimization's sake.
202202
// Said hook is later but shouldn't matter in this case, the purpose is to force redraw on every frame.
203203
/*
204204
DEFINE_HOOK(0x43FDD6, BuildingClass_AI_Airstrike, 0x6)

src/Ext/Techno/Hooks.Firing.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -709,7 +709,7 @@ DEFINE_HOOK(0x6FF29E, TechnoClass_FireAt_ChargeTurret2, 0x6)
709709
// and neither Ares nor Phobos has touched it, even that crawling flh one was in TechnoClass
710710
DEFINE_JUMP(VTABLE, 0x7F5D20, 0x523250);// Redirect UnitClass::GetFLH to InfantryClass::GetFLH (used to be TechnoClass::GetFLH)
711711

712-
// 4.4.2025 - Starkku: Consolidated all the FLH hooks into single one & using TechnoExt::GetFLHAbsoluteCoord() to get the actual coordinate.
712+
// Apr 4, 2025 - Starkku: Consolidated all the FLH hooks into single one & using TechnoExt::GetFLHAbsoluteCoord() to get the actual coordinate.
713713
DEFINE_HOOK(0x6F3AEB, TechnoClass_GetFLH, 0x6)
714714
{
715715
enum { SkipGameCode = 0x6F3D50 };

src/Ext/Techno/Hooks.Misc.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -722,9 +722,9 @@ void __fastcall DisplayClass_Submit_Wrapper(DisplayClass* pThis, void* _, Object
722722
DEFINE_FUNCTION_JUMP(CALL, 0x54B18E, DisplayClass_Submit_Wrapper); // JumpjetLocomotionClass_Process
723723
DEFINE_FUNCTION_JUMP(CALL, 0x4CD4E7, DisplayClass_Submit_Wrapper); // FlyLocomotionClass_Update
724724

725-
// Fixes SecondaryFire / SecondaryProne sequences not remapping to WetAttack in water.
725+
// Oct 26, 2024 - Starkku: Fixes SecondaryFire / SecondaryProne sequences not remapping to WetAttack in water.
726726
// Ideally there would be WetAttackSecondary but adding new sequences would be a big undertaking.
727-
// Also adds a toggle for not using water sequences at all - Starkku
727+
// Also adds a toggle for not using water sequences at all
728728
DEFINE_HOOK(0x51D7E0, InfantryClass_DoAction_Water, 0x5)
729729
{
730730
enum { Continue= 0x51D7EC, SkipWaterSequences = 0x51D842, UseSwim = 0x51D83D, UseWetAttack = 0x51D82F };

src/Ext/WarheadType/Detonate.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ void WarheadTypeExt::ExtData::Detonate(TechnoClass* pOwner, HouseClass* pHouse,
178178
{
179179
if (auto pTarget = abstract_cast<TechnoClass*>(pBullet->Target))
180180
{
181-
// Starkku: We should only detonate on the target if the bullet, at the moment of detonation is within acceptable distance of the target.
181+
// Jun 2, 2024 - Starkku: We should only detonate on the target if the bullet, at the moment of detonation is within acceptable distance of the target.
182182
// Ares uses 64 leptons / quarter of a cell as a tolerance, so for sake of consistency we're gonna do the same here.
183183
if (pBullet->DistanceFrom(pTarget) < Unsorted::LeptonsPerCell / 4)
184184
this->DetonateOnOneUnit(pHouse, pTarget, pOwner, bulletWasIntercepted);

src/Misc/Hooks.BugFixes.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -632,9 +632,9 @@ DEFINE_HOOK(0x4387A8, BombClass_Detonate_ExplosionAnimHandled, 0x5)
632632
// redirect MapClass::DamageArea call to our dll for additional functionality and checks
633633
DEFINE_FUNCTION_JUMP(CALL, 0x4387A3, _BombClass_Detonate_DamageArea);
634634

635-
// BibShape checks for BuildingClass::BState which needs to not be 0 (constructing) for bib to draw.
635+
// Oct 20, 2022 - Starkku: BibShape checks for BuildingClass::BState which needs to not be 0 (constructing) for bib to draw.
636636
// It is possible for BState to be 1 early during construction for frame or two which can result in BibShape being drawn during buildup, which somehow depends on length of buildup.
637-
// Trying to fix this issue at its root is problematic and most of the time causes buildup to play twice, it is simpler to simply fix the BibShape to not draw until the buildup is done - Starkku
637+
// Trying to fix this issue at its root is problematic and most of the time causes buildup to play twice, it is simpler to simply fix the BibShape to not draw until the buildup is done
638638
DEFINE_HOOK(0x43D874, BuildingClass_Draw_BuildupBibShape, 0x6)
639639
{
640640
enum { DontDrawBib = 0x43D8EE };
@@ -905,10 +905,10 @@ DEFINE_JUMP(LJMP, 0x67F72E, 0x67F744); // Load
905905

906906
#pragma endregion save_load
907907

908-
// An attempt to fix an issue where the ATC->CurrentVector does not contain every air Techno in given range that increases in frequency as the range goes up.
908+
// Jul 14, 2024 - Starkku: An attempt to fix an issue where the ATC->CurrentVector does not contain every air Techno in given range that increases in frequency as the range goes up.
909909
// Real talk: I have absolutely no clue how the original function works besides doing vector looping and manipulation, as far as I can tell it never even explicitly
910910
// clears CurrentVector but somehow it only contains applicable items afterwards anyway. It is possible this one does not achieve everything the original does functionality and/or
911-
// performance-wise but it does work and produces results with greater accuracy than the original for large ranges. - Starkku
911+
// performance-wise but it does work and produces results with greater accuracy than the original for large ranges.
912912
DEFINE_HOOK(0x412B40, AircraftTrackerClass_FillCurrentVector, 0x5)
913913
{
914914
enum { SkipGameCode = 0x413482 };
@@ -1002,8 +1002,8 @@ DEFINE_HOOK(0x72958E, TunnelLocomotionClass_ProcessDigging_SlowdownDistance, 0x8
10021002
auto& currLoc = pLoco->LinkedTo->Location;
10031003
int distance = (int) CoordStruct{currLoc.X - pLoco->Coords.X, currLoc.Y - pLoco->Coords.Y,0}.Magnitude() ;
10041004

1005-
// The movement speed was actually also hardcoded here to 19, so the distance check made sense
1006-
// It can now be customized globally or per TechnoType however - Starkku
1005+
// Nov 27, 2024 - Starkku: The movement speed was actually also hardcoded here to 19, so the distance check made sense
1006+
// It can now be customized globally or per TechnoType however
10071007
auto const pType = pLoco->LinkedTo->GetTechnoType();
10081008
auto const pTypeExt = TechnoTypeExt::ExtMap.Find(pType);
10091009
int speed = pTypeExt->SubterraneanSpeed >= 0 ? pTypeExt->SubterraneanSpeed : RulesExt::Global()->SubterraneanSpeed;
@@ -1091,7 +1091,7 @@ DEFINE_HOOK(0x546C95, IsometricTileTypeClass_ReadINI_LunarFixes, 0x6)
10911091
return 0;
10921092
}
10931093

1094-
// Fixes an edge case that affects AI-owned technos where they lose ally targets instantly even if they have AttackFriendlies=yes - Starkku
1094+
// Oct 26, 2024 - Starkku: Fixes an edge case that affects AI-owned technos where they lose ally targets instantly even if they have AttackFriendlies=yes
10951095
DEFINE_HOOK(0x6FA467, TechnoClass_AI_AttackFriendlies, 0x5)
10961096
{
10971097
enum { SkipResetTarget = 0x6FA472 };
@@ -1106,7 +1106,7 @@ DEFINE_HOOK(0x6FA467, TechnoClass_AI_AttackFriendlies, 0x5)
11061106
return 0;
11071107
}
11081108

1109-
// Starkku: These fix issues with follower train cars etc) indices being thrown off by preplaced vehicles not being created, having other vehicles as InitialPayload etc.
1109+
// Nov 6, 2024: Starkku: These fix issues with follower train cars etc) indices being thrown off by preplaced vehicles not being created, having other vehicles as InitialPayload etc.
11101110
// This fix basically works by not using the global UnitClass array at all for setting the followers, only a list of preplaced units, successfully created or not.
11111111
#pragma region Follower
11121112

src/Utilities/Helpers.Alex.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ namespace Helpers
156156
{
157157
if (auto const pTechno = abstract_cast<TechnoClass*>(*obj))
158158
{
159-
// Starkku: Buildings need their distance from the origin coords checked at cell level.
159+
// May 22, 2024 - Starkku: Buildings need their distance from the origin coords checked at cell level.
160160
if (pTechno->WhatAmI() == AbstractType::Building)
161161
{
162162
if (static_cast<BuildingClass*>(pTechno)->Type->InvisibleInGame)
@@ -187,7 +187,7 @@ namespace Helpers
187187
}
188188

189189
// flying objects are not included normally
190-
// Starkku: Reimplemented using AircraftTrackerClass.
190+
// May 22, 2024 - Starkku: Reimplemented using AircraftTrackerClass.
191191
if (includeInAir)
192192
{
193193
auto const airTracker = &AircraftTrackerClass::Instance;

0 commit comments

Comments
 (0)