Fix VoiceDeploy not playing when deploying through hot-key/command bar. (#1115)

VoiceDeploy now plays when 1 unit is ordered to deploy through
hot-key/command bar.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Fixed an issue where the deployment sound was not played when using
hot-key/command bar for `VoiceDeploy`.
- **New Features**
- Added audio feedback for player actions through `VoiceDeploy` feature.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Belonit <[email protected]>
Co-authored-by: Coronia <[email protected]>

Author: 3 people

CREDITS.md

@@ -416,6 +416,7 @@ This page lists all the individual contributions to the project by their author.
   - Flashing Technos on selecting
   - Promotion animation
   - Damaged unit image changes
+  - `VoiceDeploy` through hot-key/command bar fix
 - **ZivDero**:
   - Re-enable the Veinhole Monster and Weeds from TS
   - Recreate the weed-charging of SWs like the TS Chemical Missile

docs/Fixed-or-Improved-Logics.md

@@ -223,6 +223,7 @@ This page describes all ingame logics that are fixed or improved in Phobos witho
 - Fixed the bug that `AllowAirstrike=no` cannot completely prevent air strikes from being launched against it.
 - Fixed the issue where computer players did not search for new enemies after defeating them or forming alliances with them.
 - Fixed the bug that infantry ignored `Passengers` and `SizeLimit` when entering buildings.
+- Fixed `VoiceDeploy` not played, when deployed through hot-key/command bar.
 
 ## Fixes / interactions with other extensions
 

docs/Whats-New.md

@@ -684,6 +684,7 @@ Vanilla fixes:
 - Fixed an issue that harvesters with amphibious movement zone can not automatically return to refineries with `WaterBound` on water surface (by NetsuNegi)
 - Fixed an issue that game crashes (EIP:7FB178) when infantry are about to enter an occupiable building that has been removed and is not real dead (by CrimRecya)
 - Fixed an issue that game crashes when spawnee has been removed and is not real dead (by CrimRecya)
+- Fixed `VoiceDeploy` not played, when deployed through hot-key/command bar (by Fryone)
 
 Phobos fixes:
 - Fixed a few errors of calling for superweapon launch by `LaunchSW` or building infiltration (by Trsdy)

src/Ext/Techno/Hooks.Misc.cpp

@@ -764,4 +764,38 @@ DEFINE_HOOK(0x70FB73, FootClass_IsBunkerableNow_Dehardcode, 0x6)
 	auto const pTypeExt = TechnoTypeExt::ExtMap.Find(pType);
 	return pTypeExt->BunkerableAnyway ? CanEnter : 0;
 }
+
+DEFINE_HOOK(0x730D1F, DeployCommandClass_Execute_VoiceDeploy, 0x5)
+{
+	GET_STACK(int, unitsToDeploy, STACK_OFFSET(0x18, -0x4));
+
+	if (unitsToDeploy != 1)
+		return 0;
+
+	GET(TechnoClass* const, pThis, ESI);
+	auto const whatAmI = pThis->WhatAmI();
+
+	if (whatAmI == AbstractType::Infantry)
+	{
+		auto pInfantry = static_cast<InfantryClass*>(pThis);
+
+		if (!pInfantry->IsDeploying)
+		{
+			if (pInfantry->IsDeployed())
+				pThis->QueueVoice(pThis->GetTechnoType()->VoiceUndeploy);
+			else
+				pThis->QueueVoice(pThis->GetTechnoType()->VoiceDeploy);
+		}
+	}
+	else if (whatAmI == AbstractType::Unit)
+	{
+		auto pUnit = static_cast<UnitClass*>(pThis);
+
+		if (pUnit->TryToDeploy() || pUnit->Type->IsSimpleDeployer)
+			pThis->QueueVoice(pThis->GetTechnoType()->VoiceDeploy);
+	}
+
+	return 0;
+}
+
 #pragma endregion