Targeting limitation for berzerk technos (#1720)

### Targeting limitation for berzerk technos

- Now you can specify which houses berzerk's technos can target and
fire.

In `rulesmd.ini`:
```ini
[General]
BerzerkTargeting=all  ; AffectedHouse enumeration
```

Author: TaranDahl

CREDITS.md

@@ -534,6 +534,7 @@ This page lists all the individual contributions to the project by their author.
   - Make harvesters do addtional scan after unload
   - Customize the scatter caused by aircraft attack mission
   - Customize whether `Crater=yes` animation would destroy tiberium
+  - Targeting limitation for berzerk technos
 - **tyuah8**:
   - Drive/Jumpjet/Ship/Teleport locomotor did not power on when it is un-piggybacked bugfix
   - Destroyed unit leaves sensors bugfix

docs/New-or-Enhanced-Logics.md

@@ -1707,6 +1707,16 @@ IsVoiceCreatedGlobal=false   ; boolean
 VoiceCreated=                ; Sound entry
 ```
 
+### Targeting limitation for berzerk technos
+
+- Now you can specify which houses berzerk's technos can target and fire.
+
+In `rulesmd.ini`:
+```ini
+[General]
+BerzerkTargeting=all  ; AffectedHouse enumeration
+```
+
 ### Tiberium eater
 
 - TechnoTypes can convert the ores underneath them into credits in real time, like GDI's MARV in Command & Conquer 3 Kane's Wrath.

docs/Whats-New.md

@@ -391,6 +391,7 @@ New:
 - [Turretless vehicles with `Voxel=no` support use `FireUp` like infantry](New-or-Enhanced-Logics.md#turretless-shape-vehicle-fireup) (by FlyStar)
 - Infantry support `IsGattling=yes` (by FlyStar)
 - [Several new Infotypes, no display in specific status and a new single frame display method](User-Interface.md#digital-display) (by CrimRecya)
+- Targeting limitation for berzerk technos (by TaranDahl)
 
 Vanilla fixes:
 - Fixed sidebar not updating queued unit numbers when adding or removing units when the production is on hold (by CrimRecya)

src/Ext/Rules/Body.cpp

@@ -273,6 +273,8 @@ void RulesExt::ExtData::LoadBeforeTypeData(RulesClass* pThis, CCINIClass* pINI)
 
 	this->AnimCraterDestroyTiberium.Read(exINI, GameStrings::General, "AnimCraterDestroyTiberium");
 
+	this->BerzerkTargeting.Read(exINI, GameStrings::CombatDamage, "BerzerkTargeting");
+	
 	// Section AITargetTypes
 	int itemsCount = pINI->GetKeyCount("AITargetTypes");
 	for (int i = 0; i < itemsCount; ++i)
@@ -501,6 +503,7 @@ void RulesExt::ExtData::Serialize(T& Stm)
 		.Process(this->DamagedSpeed)
 		.Process(this->HarvesterScanAfterUnload)
 		.Process(this->AnimCraterDestroyTiberium)
+		.Process(this->BerzerkTargeting)
 		;
 }
 

src/Ext/Rules/Body.h

@@ -228,6 +228,8 @@ class RulesExt
 
 		Valueable<bool> AnimCraterDestroyTiberium;
 
+		Valueable<AffectedHouse> BerzerkTargeting;
+		
 		ExtData(RulesClass* OwnerObject) : Extension<RulesClass>(OwnerObject)
 			, Storage_TiberiumIndex { -1 }
 			, HarvesterDumpAmount { 0.0f }
@@ -401,6 +403,8 @@ class RulesExt
 			, HarvesterScanAfterUnload { false }
 
 			, AnimCraterDestroyTiberium { true }
+			
+			, BerzerkTargeting { AffectedHouse::All }
 		{ }
 
 		virtual ~ExtData() = default;

src/Ext/Techno/Hooks.Firing.cpp

@@ -1,4 +1,4 @@
-#include "Body.h"
+#include "Body.h"
 
 #include <OverlayTypeClass.h>
 #include <ScenarioClass.h>
@@ -248,6 +248,7 @@ DEFINE_HOOK(0x6FC339, TechnoClass_CanFire, 0x6)
 	GET(TechnoClass*, pThis, ESI);
 	GET(WeaponTypeClass*, pWeapon, EDI);
 	GET_STACK(AbstractClass*, pTarget, STACK_OFFSET(0x20, 0x4));
+	GET(TechnoClass*, pTargetTechno, EBP);
 
 	// Checking for nullptr is not required here, since the game has already executed them before calling the hook  -- Belonit
 	const auto pWH = pWeapon->Warhead;
@@ -268,15 +269,14 @@ DEFINE_HOOK(0x6FC339, TechnoClass_CanFire, 0x6)
 		return CannotFire;
 	}
 
-	const auto pTechno = abstract_cast<TechnoClass*>(pTarget);
 	CellClass* pTargetCell = nullptr;
 
 	if (pTarget)
 	{
 		if (const auto pObject = abstract_cast<ObjectClass*, true>(pTarget))
 		{
 			// Ignore target cell for technos that are in air.
-			if ((pTechno && !pTechno->IsInAir()) || pObject != pTechno)
+			if ((pTargetTechno && !pTargetTechno->IsInAir()) || pObject != pTargetTechno)
 				pTargetCell = pObject->GetCell();
 		}
 		else if (const auto pCell = abstract_cast<CellClass*, true>(pTarget))
@@ -293,25 +293,31 @@ DEFINE_HOOK(0x6FC339, TechnoClass_CanFire, 0x6)
 		return CannotFire;
 	}
 
-	if (pTechno)
+	if (pTargetTechno)
 	{
+		if (pThis->Berzerk
+			&& !EnumFunctions::CanTargetHouse(RulesExt::Global()->BerzerkTargeting, pThis->Owner, pTargetTechno->Owner))
+		{
+			return CannotFire;
+		}
+
 		if (!pWeaponExt->SkipWeaponPicking)
 		{
-			if (!EnumFunctions::IsTechnoEligible(pTechno, pWeaponExt->CanTarget)
-				|| !EnumFunctions::CanTargetHouse(pWeaponExt->CanTargetHouses, pThis->Owner, pTechno->Owner)
-				|| !pWeaponExt->IsHealthRatioEligible(pTechno)
-				|| !pWeaponExt->HasRequiredAttachedEffects(pTechno, pThis))
+			if (!EnumFunctions::IsTechnoEligible(pTargetTechno, pWeaponExt->CanTarget)
+				|| !EnumFunctions::CanTargetHouse(pWeaponExt->CanTargetHouses, pThis->Owner, pTargetTechno->Owner)
+				|| !pWeaponExt->IsHealthRatioEligible(pTargetTechno)
+				|| !pWeaponExt->HasRequiredAttachedEffects(pTargetTechno, pThis))
 			{
 				return CannotFire;
 			}
 		}
 
 		if (pWH->Airstrike)
 		{
-			if (!pWHExt || !EnumFunctions::IsTechnoEligible(pTechno, pWHExt->AirstrikeTargets))
+			if (!pWHExt || !EnumFunctions::IsTechnoEligible(pTargetTechno, pWHExt->AirstrikeTargets))
 				return CannotFire;
 
-			if (!TechnoTypeExt::ExtMap.Find(pTechno->GetTechnoType())->AllowAirstrike.Get(pTechno->AbstractFlags & AbstractFlags::Foot ? true : static_cast<BuildingClass*>(pTechno)->Type->CanC4))
+			if (!TechnoTypeExt::ExtMap.Find(pTargetTechno->GetTechnoType())->AllowAirstrike.Get(pTargetTechno->AbstractFlags & AbstractFlags::Foot ? true : static_cast<BuildingClass*>(pTargetTechno)->Type->CanC4))
 				return CannotFire;
 		}
 	}