Start PhotonVision after network.target is reached (#114)

PV tries to access networking information fairly early in the startup
process and, when NetworkManager isn't ready, PV cannot get the
information it needs about the network hardware.

This PR configures the photonvision service to start after
NetworkManager is running. The change is only made when PV is configured
to manage networking.

This should reduce the need for
PhotonVision/photonvision#2240, but it's safer
to have both.

Author: crschardt

install.sh

@@ -111,6 +111,7 @@ if grep -iq "systemcore" /etc/os-release; then
 fi
 
 INSTALL_NETWORK_MANAGER="ask"
+DISABLE_NETWORKING="false"
 VERSION="latest"
 
 while getopts "hlva:mnqt-:" OPT; do
@@ -228,7 +229,7 @@ DISTRO=$(lsb_release -is)
 # i.e. the distro is Ubuntu, you haven't requested disabling networking,
 # and you have requested a quiet install.
 if [[ "$INSTALL_NETWORK_MANAGER" == "ask" ]]; then
-  if [[ "$DISTRO" != "Ubuntu" || -n "$DISABLE_NETWORKING" || -n "$QUIET" ]] ; then
+  if [[ "$DISTRO" != "Ubuntu" || "$DISABLE_NETWORKING" == "true" || -n "$QUIET" ]] ; then
     INSTALL_NETWORK_MANAGER="no"
   fi
 fi
@@ -301,7 +302,6 @@ debug "Downloaded PhotonVision."
 
 debug "Creating the PhotonVision systemd service..."
 
-
 if [[ -z $TEST ]]; then
   # service --status-all doesn't list photonvision on OrangePi use systemctl instead:
   if [[ $(systemctl --quiet is-active photonvision) = "active" ]]; then
@@ -317,6 +317,8 @@ if [[ -z $TEST ]]; then
   cat > /lib/systemd/system/photonvision.service <<EOF
 [Unit]
 Description=Service that runs PhotonVision
+# Uncomment the next line to have photonvision startup wait for NetworkManager startup
+# After=network.target
 
 [Service]
 WorkingDirectory=/opt/photonvision
@@ -336,8 +338,12 @@ RestartSec=1
 WantedBy=multi-user.target
 EOF
 
-  if [ "$DISABLE_NETWORKING" = "true" ]; then
+  if [[ "$DISABLE_NETWORKING" == "true" ]]; then
+    debug "Adding -n switch to photonvision startup to disable network management"
     sed -i "s/photonvision.jar/photonvision.jar -n/" /lib/systemd/system/photonvision.service
+  else
+    debug "Setting photonvision.service to start after network.target is reached"
+    sed -i "s/# After=network.target/After=network.target/g" /lib/systemd/system/photonvision.service
   fi
 
   if grep -q "RK3588" /proc/cpuinfo; then