Do not close the RawFrame in VideoSimUtil.get36h11TagImage()

Author: kcooney

photon-lib/src/main/java/org/photonvision/simulation/VideoSimUtil.java

@@ -100,13 +100,18 @@ public static Point[] getImageCorners(Size size) {
     /**
      * Gets the 10x10 (grayscale) image of a specific 36h11 AprilTag.
      *
+     * <p>WARNING: This creates a {@link RawFrame} instance but does not close it, which would result
+     * in a resource leak if the {@link Mat} is garbage-collected. Unfortunately, closing the {@code
+     * RawFrame} inside this function would delete the underlying data that backs the {@code
+     * ByteBuffer} that is passed to the {@code Mat} constructor. See comments on <a
+     * href="https://github.com/PhotonVision/photonvision/pull/2023">PR 2023</a> for details.
+     *
      * @param id The fiducial id of the desired tag
      */
     private static Mat get36h11TagImage(int id) {
-        try (RawFrame frame = AprilTag.generate36h11AprilTagImage(id)) {
-            return new Mat(
-                    frame.getHeight(), frame.getWidth(), CvType.CV_8UC1, frame.getData(), frame.getStride());
-        }
+        RawFrame frame = AprilTag.generate36h11AprilTagImage(id);
+        return new Mat(
+                frame.getHeight(), frame.getWidth(), CvType.CV_8UC1, frame.getData(), frame.getStride());
     }
 
     /** Gets the points representing the marker(black square) corners. */