Skip to content

Commit 847386d

Browse files
committed
remove LED and GPIO support
1 parent 2eb224a commit 847386d

File tree

64 files changed

+11
-2318
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+11
-2318
lines changed

docs/source/docs/additional-resources/config.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ The directory structure is outlined below.
2222
- Contains images saved with the input/output save commands.
2323
- logs
2424
- Contains timestamped logs in the format {code}`photonvision-YYYY-MM-D_HH-MM-SS.log`. These timestamps will likely be significantly behind the real time. Coprocessors on the robot have no way to get current time.
25-
- hardwareSettings.json
26-
- Contains hardware settings. Currently this includes only the LED brightness.
2725
- networkSettings.json
2826
- Contains network settings, including team number (or remote network tables address), static/dynamic settings, and hostname.
2927

@@ -45,7 +43,6 @@ A variety of files can be imported back into PhotonVision:
4543
- Single Config File
4644
- Currently-supported Files
4745
- {code}`hardwareConfig.json`
48-
- {code}`hardwareSettings.json`
4946
- {code}`networkSettings.json`
5047
- Useful for simple hardware or network configuration tasks without overwriting all settings.
5148

docs/source/docs/additional-resources/nt-api.md

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -54,17 +54,3 @@ Images are returned as part of the .zip package from the "Export" operation in t
5454
:::{warning}
5555
If you manage to make calls to these commands faster than 500ms (between calls), additional photos will not be captured.
5656
:::
57-
58-
### Global Entries
59-
60-
These entries are global, meaning that they should be called on the main `photonvision` table.
61-
62-
| Key | Type | Description |
63-
| --------- | ----- | -------------------------------------------------------- |
64-
| `ledMode` | `int` | Sets the LED Mode (-1: default, 0: off, 1: on, 2: blink) |
65-
66-
:::{warning}
67-
Setting the LED mode to -1 (default) when `multiple` cameras are connected may result in unexpected behavior. {ref}`This is a known limitation of PhotonVision. <docs/troubleshooting/common-errors:LED Control>`
68-
69-
Single camera operation should work without issue.
70-
:::
Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
{
22
"deviceName" : "Limelight 2+",
33
"supportURL" : "https://limelightvision.io",
4-
"ledPins" : [ 13, 18 ],
5-
"ledsCanDim" : true,
6-
"ledPWMRange" : [ 0, 100 ],
7-
"ledPWMFrequency" : 30000,
84
"vendorFOV" : 75.76079874010732
95
}
Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
{
22
"deviceName" : "Limelight 2",
33
"supportURL" : "https://limelightvision.io",
4-
"ledPins" : [ 17, 18 ],
5-
"ledsCanDim" : false,
64
"vendorFOV" : 75.76079874010732
75
}

docs/source/docs/hardware/customhardware.md

Lines changed: 1 addition & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -2,35 +2,10 @@
22

33
## Configuration
44

5-
By default, PhotonVision attempts to make minimal assumptions of the hardware it runs on. However, it may be configured to enable custom LED control, branding, and other functionality.
5+
By default, PhotonVision attempts to make minimal assumptions of the hardware it runs on. However, it may be configured to enable branding and other functionality.
66

77
`hardwareConfig.json` is the location for this configuration. It is included when settings are exported, and can be uploaded as part of a .zip, or on its own.
88

9-
## LED Support
10-
11-
For Raspberry-Pi based hardware, PhotonVision can use [PiGPIO](https://abyz.me.uk/rpi/pigpio/) to control IO pins. The mapping of which pins control which LED's is part of the hardware config. The pins are active-high: set high when LED's are commanded on, and set low when commanded off.
12-
13-
```{eval-rst}
14-
.. tab-set-code::
15-
.. code-block:: json
16-
17-
{
18-
"ledPins" : [ 13 ],
19-
"ledSetCommand" : "",
20-
"ledsCanDim" : true,
21-
"ledPWMRange" : [ 0, 100 ],
22-
"ledPWMSetRange" : "",
23-
"ledPWMFrequency" : 0,
24-
"ledDimCommand" : "",
25-
"ledBlinkCommand" : "",
26-
"statusRGBPins" : [ ],
27-
}
28-
```
29-
30-
:::{note}
31-
No hardware boards with status RGB LED pins or non-dimming LED's have been tested yet. Please reach out to the development team if these features are desired, they can assist with configuration and testing.
32-
:::
33-
349
## Hardware Interaction Commands
3510

3611
For Non-Raspberry-Pi hardware, users must provide valid hardware-specific commands for some parts of the UI interaction (including performance metrics, and executing system restarts).
@@ -100,15 +75,6 @@ Here is a complete example `hardwareConfig.json`:
10075
"deviceName" : "Blinky McBlinkface",
10176
"deviceLogoPath" : "",
10277
"supportURL" : "https://www.youtube.com/watch?v=b-CvLWbfZhU",
103-
"ledPins" : [2, 13],
104-
"ledSetCommand" : "",
105-
"ledsCanDim" : true,
106-
"ledPWMRange" : [ 0, 100 ],
107-
"ledPWMSetRange" : "",
108-
"ledPWMFrequency" : 0,
109-
"ledDimCommand" : "",
110-
"ledBlinkCommand" : "",
111-
"statusRGBPins" : [ ],
11278
"cpuTempCommand" : "",
11379
"cpuMemoryCommand" : "",
11480
"cpuUtilCommand" : "",

docs/source/docs/programming/photonlib/controlling-led.md

Lines changed: 0 additions & 20 deletions
This file was deleted.

docs/source/docs/programming/photonlib/index.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,4 @@ getting-target-data
88
using-target-data
99
robot-pose-estimator
1010
driver-mode-pipeline-index
11-
controlling-led
1211
```

docs/source/docs/troubleshooting/common-errors.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,6 @@ All known issues can be found on our [GitHub page](https://github.com/PhotonVisi
1010

1111
Due to an issue with Linux kernels, the drivers for the PS3Eye are no longer supported. If you would still like to use the PS3Eye, you can downgrade your kernel with the following command: `sudo CURL_CA_BUNDLE=/etc/ssl/certs/ca-certificates.crt rpi-update 866751bfd023e72bd96a8225cf567e03c334ecc4`. Note: You must be connected to the internet to run the command.
1212

13-
### LED Control
14-
15-
The logic for controlling LED mode when `multiple cameras are connected` is not fully fleshed out. In its current state, LED control is only enabled when a Pi Camera Module is not in driver mode—meaning a USB camera on its own is unable to control the LEDs.
16-
17-
For now, if you are using multiple cameras, it is recommended that teams set the value of the NetworkTables entry {code}`photonvision/ledMode` from the robot code to control LED state.
18-
1913
## Commonly Seen Issues
2014

2115
### Networking Issues

photon-client/src/components/settings/DeviceControlCard.vue

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,6 @@ const openExportSettingsPrompt = () => {
133133
enum ImportType {
134134
AllSettings,
135135
HardwareConfig,
136-
HardwareSettings,
137136
NetworkConfig,
138137
ApriltagFieldLayout
139138
}
@@ -151,9 +150,6 @@ const handleSettingsImport = () => {
151150
case ImportType.HardwareConfig:
152151
settingsEndpoint = "/hardwareConfig";
153152
break;
154-
case ImportType.HardwareSettings:
155-
settingsEndpoint = "/hardwareSettings";
156-
break;
157153
case ImportType.NetworkConfig:
158154
settingsEndpoint = "/networkConfig";
159155
break;

photon-client/src/components/settings/LEDControlCard.vue

Lines changed: 0 additions & 19 deletions
This file was deleted.

0 commit comments

Comments
 (0)