Skip to content

Commit 0ce2dd4

Browse files
authored
Fix Error Prone compatibility check (#1942)
The check now gracefully handles references to checks that have been deleted, and no longer fails on new warnings introduced by the latest release.
1 parent f3d5ba5 commit 0ce2dd4

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

.github/workflows/error-prone-compat.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,9 @@ jobs:
4444
- name: Quickly build and install project
4545
run: mvn install -Dverification.skip
4646
- name: Build and test project with self-check against the latest Error Prone release
47-
run: mvn clean verify -s settings.xml -Pself-check -Dversion.error-prone=LATEST -Denforcer.skip -Dmdep.analyze.skip
47+
# Note that it is okay for the build to reference checks that have been
48+
# deleted in the latest release, or to trigger new warnings; those
49+
# don't indicate that Error Prone Support is incompatible with the
50+
# latest Error Prone release as far as downstream users are concerned.
51+
# XXX: This use of `error-prone.patch-args` is a bit dodgy...
52+
run: mvn clean verify -s settings.xml -Pself-check -Dversion.error-prone=LATEST -Derror-prone.patch-args=-XepIgnoreUnknownCheckNames -Dverification.warn

0 commit comments

Comments
 (0)