Suggestions

Author: Stephan202

error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/RandomGeneratorRules.java

@@ -32,9 +32,12 @@ static final class RandomGeneratorNextDouble {
   }
 
   /**
-   * Prefer {@link RandomGenerator#nextDouble(double origin, double bound)} over more contrived
-   * alternatives.
+   * Prefer {@link RandomGenerator#nextDouble(double origin, double bound)} over alternatives that
+   * may silently yield an ununiform domain of values.
    */
+  // XXX: This rule assumes that `a` is not an expensive or side-effectful expression.
+  // XXX: The replacement code throws an `IllegalArgumentException` in more cases than the original
+  // code, but only in situations that are likely unintended.
   static final class RandomGeneratorNextDoubleWithOrigin {
     @BeforeTemplate
     double before(RandomGenerator random, double a, double b) {
@@ -63,8 +66,12 @@ int after(RandomGenerator random, int bound) {
   }
 
   /**
-   * Prefer {@link RandomGenerator#nextInt(int origin, int bound)} over more contrived alternatives.
+   * Prefer {@link RandomGenerator#nextInt(int origin, int bound)} over alternatives that may
+   * silently yield values outside the intended domain.
    */
+  // XXX: This rule assumes that `a` is not an expensive or side-effectful expression.
+  // XXX: The replacement code throws an `IllegalArgumentException` in more cases than the original
+  // code, but only in situations that are likely unintended.
   static final class RandomGeneratorNextIntWithOrigin {
     @BeforeTemplate
     int before(RandomGenerator random, int a, int b) {
@@ -111,6 +118,9 @@ long after(RandomGenerator random, long bound) {
    * Prefer {@link RandomGenerator#nextLong(long origin, long bound)} over more contrived
    * alternatives.
    */
+  // XXX: This rule assumes that `a` is not an expensive or side-effectful expression.
+  // XXX: The replacement code throws an `IllegalArgumentException` in more cases than the original
+  // code, but only in situations that are likely unintended.
   static final class RandomGeneratorNextLongWithOrigin {
     @BeforeTemplate
     long before(RandomGenerator random, long a, long b) {

refaster-support/src/main/java/tech/picnic/errorprone/refaster/matchers/RequiresComputation.java

@@ -14,7 +14,7 @@
 import com.sun.source.tree.TypeCastTree;
 import com.sun.source.tree.UnaryTree;
 
-/** A matcher of expressions that may a non-trivial amount of computation. */
+/** A matcher of expressions that may require a non-trivial amount of computation. */
 public final class RequiresComputation implements Matcher<ExpressionTree> {
   private static final long serialVersionUID = 1L;