Skip to content

Commit 5679391

Browse files
Picnic-DevPla-BotPicnic-DevPla-Bot
authored
Upgrade Error Prone 2.43.0 -> 2.44.0 (#1963)
See: - https://github.com/google/error-prone/releases/tag/v2.44.0 - google/error-prone@v2.43.0...v2.44.0 - PicnicSupermarket/error-prone@v2.43.0-picnic-1...v2.44.0-picnic-1
1 parent c88470b commit 5679391

File tree

9 files changed

+19
-19
lines changed

9 files changed

+19
-19
lines changed

‎documentation-support/src/main/java/tech/picnic/errorprone/documentation/BugPatternExtractor.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ private static ImmutableList<String> getSuppressionAnnotations(ClassTree tree) {
8585
.collect(toImmutableList());
8686
}
8787

88-
@SuppressWarnings("unchecked")
88+
@SuppressWarnings("unchecked" /* Type safety is validated, but a caller responsibility. */)
8989
private static <T extends AnnotationValue> T doCast(AnnotationValue value, Class<T> target) {
9090
verify(target.isInstance(value), "Value '%s' is not of type '%s'", value, target);
9191
return (T) value;

‎documentation-support/src/main/java/tech/picnic/errorprone/documentation/DocumentationGeneratorTaskListener.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
*/
2727
// XXX: Find a better name for this class; it doesn't generate documentation per se.
2828
final class DocumentationGeneratorTaskListener implements TaskListener {
29-
@SuppressWarnings({"rawtypes", "unchecked"})
29+
@SuppressWarnings({"rawtypes", "unchecked"} /* Unbounded wildcard type introduction is safe. */)
3030
private static final ImmutableList<Extractor<?>> EXTRACTORS =
3131
(ImmutableList)
3232
ImmutableList.copyOf(

‎error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJEnumerableRules.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ void before(
3131
}
3232

3333
@BeforeTemplate
34-
@SuppressWarnings("unchecked")
34+
@SuppressWarnings("unchecked" /* Safe generic array type creation. */)
3535
void before(
3636
ObjectEnumerableAssert<?, E> enumAssert,
3737
@Matches(IsEmpty.class) Iterable<? extends E> emptyIterable) {

‎error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJRules.java‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ OptionalLongAssert after(OptionalLong optional, long expected) {
169169

170170
static final class ObjectEnumerableContainsOneElement<S, T extends S> {
171171
@BeforeTemplate
172-
@SuppressWarnings("unchecked")
172+
@SuppressWarnings("unchecked" /* Safe generic array type creation. */)
173173
ObjectEnumerableAssert<?, S> before(ObjectEnumerableAssert<?, S> iterAssert, T element) {
174174
return Refaster.anyOf(
175175
iterAssert.containsAnyOf(element),
@@ -178,36 +178,36 @@ ObjectEnumerableAssert<?, S> before(ObjectEnumerableAssert<?, S> iterAssert, T e
178178
}
179179

180180
@AfterTemplate
181-
@SuppressWarnings("unchecked")
181+
@SuppressWarnings("unchecked" /* Safe generic array type creation. */)
182182
ObjectEnumerableAssert<?, S> after(ObjectEnumerableAssert<?, S> iterAssert, T element) {
183183
return iterAssert.contains(element);
184184
}
185185
}
186186

187187
static final class ObjectEnumerableDoesNotContainOneElement<S, T extends S> {
188188
@BeforeTemplate
189-
@SuppressWarnings("unchecked")
189+
@SuppressWarnings("unchecked" /* Safe generic array type creation. */)
190190
ObjectEnumerableAssert<?, S> before(ObjectEnumerableAssert<?, S> iterAssert, T element) {
191191
return iterAssert.doesNotContainSequence(element);
192192
}
193193

194194
@AfterTemplate
195-
@SuppressWarnings("unchecked")
195+
@SuppressWarnings("unchecked" /* Safe generic array type creation. */)
196196
ObjectEnumerableAssert<?, S> after(ObjectEnumerableAssert<?, S> iterAssert, T element) {
197197
return iterAssert.doesNotContain(element);
198198
}
199199
}
200200

201201
static final class ObjectEnumerableContainsExactlyOneElement<S, T extends S> {
202202
@BeforeTemplate
203-
@SuppressWarnings("unchecked")
203+
@SuppressWarnings("unchecked" /* Safe generic array type creation. */)
204204
ObjectEnumerableAssert<?, S> before(
205205
ObjectEnumerableAssert<?, S> iterAssert, @NotMatches(IsArray.class) T element) {
206206
return iterAssert.containsExactlyInAnyOrder(element);
207207
}
208208

209209
@AfterTemplate
210-
@SuppressWarnings("unchecked")
210+
@SuppressWarnings("unchecked" /* Safe generic array type creation. */)
211211
ObjectEnumerableAssert<?, S> after(ObjectEnumerableAssert<?, S> iterAssert, T element) {
212212
return iterAssert.containsExactly(element);
213213
}

‎error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableEnumSetRules.java‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ ImmutableSet<T> before(T e1) {
8888
}
8989

9090
@AfterTemplate
91-
@SuppressWarnings("unchecked")
91+
@SuppressWarnings("unchecked" /* Safe generic array type creation. */)
9292
ImmutableSet<T> after(T e1) {
9393
return Sets.immutableEnumSet(e1);
9494
}
@@ -110,7 +110,7 @@ ImmutableSet<T> before(T e1, T e2) {
110110
}
111111

112112
@AfterTemplate
113-
@SuppressWarnings("unchecked")
113+
@SuppressWarnings("unchecked" /* Safe generic array type creation. */)
114114
ImmutableSet<T> after(T e1, T e2) {
115115
return Sets.immutableEnumSet(e1, e2);
116116
}
@@ -133,7 +133,7 @@ ImmutableSet<T> before(T e1, T e2, T e3) {
133133
}
134134

135135
@AfterTemplate
136-
@SuppressWarnings("unchecked")
136+
@SuppressWarnings("unchecked" /* Safe generic array type creation. */)
137137
ImmutableSet<T> after(T e1, T e2, T e3) {
138138
return Sets.immutableEnumSet(e1, e2, e3);
139139
}
@@ -156,7 +156,7 @@ ImmutableSet<T> before(T e1, T e2, T e3, T e4) {
156156
}
157157

158158
@AfterTemplate
159-
@SuppressWarnings("unchecked")
159+
@SuppressWarnings("unchecked" /* Safe generic array type creation. */)
160160
ImmutableSet<T> after(T e1, T e2, T e3, T e4) {
161161
return Sets.immutableEnumSet(e1, e2, e3, e4);
162162
}
@@ -179,7 +179,7 @@ ImmutableSet<T> before(T e1, T e2, T e3, T e4, T e5) {
179179
}
180180

181181
@AfterTemplate
182-
@SuppressWarnings("unchecked")
182+
@SuppressWarnings("unchecked" /* Safe generic array type creation. */)
183183
ImmutableSet<T> after(T e1, T e2, T e3, T e4, T e5) {
184184
return Sets.immutableEnumSet(e1, e2, e3, e4, e5);
185185
}
@@ -200,7 +200,7 @@ ImmutableSet<T> before(T e1, T e2, T e3, T e4, T e5, T e6) {
200200
}
201201

202202
@AfterTemplate
203-
@SuppressWarnings("unchecked")
203+
@SuppressWarnings("unchecked" /* Safe generic array type creation. */)
204204
ImmutableSet<T> after(T e1, T e2, T e3, T e4, T e5, T e6) {
205205
return Sets.immutableEnumSet(e1, e2, e3, e4, e5, e6);
206206
}

‎error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/MockitoRules.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ Object after(InvocationOnMock invocation, int i) {
6767

6868
static final class InvocationOnMockGetArgumentsWithTypeParameter<T> {
6969
@BeforeTemplate
70-
@SuppressWarnings("unchecked")
70+
@SuppressWarnings("unchecked" /* Cast is presumed safe in matched context. */)
7171
T before(InvocationOnMock invocation, int i) {
7272
return Refaster.anyOf(
7373
invocation.getArgument(i, Refaster.<T>clazz()), (T) invocation.getArgument(i));

‎error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2345,7 +2345,7 @@ StepVerifier after(StepVerifier stepVerifier) {
23452345
/** Don't unnecessarily have {@link StepVerifier.Step} expect no elements. */
23462346
static final class StepVerifierStepIdentity<T> {
23472347
@BeforeTemplate
2348-
@SuppressWarnings("unchecked")
2348+
@SuppressWarnings("unchecked" /* Safe generic array type creation. */)
23492349
StepVerifier.Step<T> before(
23502350
StepVerifier.Step<T> step, @Matches(IsEmpty.class) Iterable<? extends T> iterable) {
23512351
return Refaster.anyOf(

‎error-prone-utils/src/main/java/tech/picnic/errorprone/utils/MoreTypes.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ public static Supplier<Type> subOf(Supplier<Type> type) {
114114
}
115115

116116
/**
117-
* Creates an unbound wildcard type ({@code ?}).
117+
* Creates an unbounded wildcard type ({@code ?}).
118118
*
119119
* @return A supplier which returns the described type.
120120
*/

‎pom.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@
202202
<version.auto-value>1.11.0</version.auto-value>
203203
<version.error-prone>${version.error-prone-orig}</version.error-prone>
204204
<version.error-prone-fork>${version.error-prone-orig}-picnic-1</version.error-prone-fork>
205-
<version.error-prone-orig>2.43.0</version.error-prone-orig>
205+
<version.error-prone-orig>2.44.0</version.error-prone-orig>
206206
<version.jdk>21</version.jdk>
207207
<version.maven>3.9.11</version.maven>
208208
<version.pitest-git>2.2.5</version.pitest-git>

0 commit comments

Comments
 (0)