Fix integration tests (#2004)

This updates the tests in accordance with the changes in
5363559. The new changes require that
the integration test projects now target Java 21 for main and test code.

Author: Stephan202

integration-tests/checkstyle-expected-changes.patch

@@ -6,7 +6,7 @@ test_name="$(basename "${0}" .sh)"
 project='checkstyle'
 repository='https://github.com/checkstyle/checkstyle.git'
 revision='checkstyle-12.0.1'
-additional_build_flags='-Perror-prone-compile,error-prone-test-compile -Dmaven.compiler.failOnError=true'
+additional_build_flags='-Djava.version=21 -Perror-prone-compile,error-prone-test-compile -Dmaven.compiler.failOnError=true'
 additional_source_directories='${project.basedir}${file.separator}src${file.separator}it${file.separator}java,${project.basedir}${file.separator}src${file.separator}xdocs-examples${file.separator}java'
 shared_error_prone_flags='-XepExcludedPaths:(\Q${project.basedir}${file.separator}src${file.separator}\E(it|test|xdocs-examples)\Q${file.separator}resources\E|\Q${project.build.directory}${file.separator}\E).*'
 patch_error_prone_flags=''

integration-tests/checkstyle.sh

@@ -3434,7 +3434,13 @@
 
      for (int i = 0; i < threadCount; i++) {
        new Thread(
-@@ -898,7 +901,7 @@ class MetricNameTest {
+@@ -893,12 +896,12 @@ class MetricNameTest {
+     latch.await(5, TimeUnit.SECONDS);
+ 
+     if (!exceptions.isEmpty()) {
+-      throw new AssertionError("Thread safety test failed: " + exceptions.get(0).getMessage());
++      throw new AssertionError("Thread safety test failed: " + exceptions.getFirst().getMessage());
+     }
    }
 
    @Test
@@ -5175,6 +5181,18 @@
 
    private CompiledScript unpickleScript;
 
+@@ -166,9 +166,9 @@ class PickledGraphiteTest {
+ 
+     for (Object aResult : result) {
+       PyTuple datapoint = (PyTuple) aResult;
+-      String name = datapoint.get(0).toString();
++      String name = datapoint.getFirst().toString();
+       PyTuple valueTuple = (PyTuple) datapoint.get(1);
+-      Object timestamp = valueTuple.get(0);
++      Object timestamp = valueTuple.getFirst();
+       Object value = valueTuple.get(1);
+ 
+       results.append(name).append(" ").append(value).append(" ").append(timestamp).append("\n");
 --- a/metrics-healthchecks/src/main/java/io/dropwizard/metrics5/health/AsyncHealthCheckDecorator.java
 +++ b/metrics-healthchecks/src/main/java/io/dropwizard/metrics5/health/AsyncHealthCheckDecorator.java
 @@ -1,5 +1,7 @@

integration-tests/metrics-expected-changes.patch

@@ -12,6 +12,7 @@ metrics-core/src/main/java/io/dropwizard/metrics5/InstrumentedExecutorService.ja
 metrics-core/src/main/java/io/dropwizard/metrics5/MetricRegistry.java:[56,27] [this-escape] possible 'this' escape before subclass is fully initialized
 metrics-core/src/main/java/io/dropwizard/metrics5/ScheduledReporter.java:[40,12] [removal] SecurityManager in java.lang has been deprecated and marked for removal
 metrics-core/src/main/java/io/dropwizard/metrics5/ScheduledReporter.java:[40,38] [removal] getSecurityManager() in System has been deprecated and marked for removal
+metrics-core/src/test/java/io/dropwizard/metrics5/MetricNameTest.java:[882,83] [deprecation] getId() in Thread has been deprecated
 metrics-graphite/src/main/java/io/dropwizard/metrics5/graphite/GraphiteReporter.java:[431,17] [Slf4jLogStatement] Log statement contains 0 placeholders, but specifies 1 matching argument(s)
 metrics-graphite/src/main/java/io/dropwizard/metrics5/graphite/GraphiteReporter.java:[436,19] [Slf4jLogStatement] Log statement contains 0 placeholders, but specifies 1 matching argument(s)
 metrics-graphite/src/main/java/io/dropwizard/metrics5/graphite/GraphiteReporter.java:[449,20] [Slf4jLogStatement] Log statement contains 0 placeholders, but specifies 1 matching argument(s)

integration-tests/metrics-expected-warnings.txt

@@ -87,3 +87,12 @@
                                  </path>
                              </annotationProcessorPaths>
                          </configuration>
+@@ -283,7 +316,7 @@
+                 <groupId>org.apache.maven.plugins</groupId>
+                 <artifactId>maven-compiler-plugin</artifactId>
+                 <configuration>
+-                    <release>17</release>
++                    <release>21</release>
+                     <fork>true</fork>
+                     <parameters>true</parameters>
+                     <showWarnings>true</showWarnings>

integration-tests/metrics-init.patch

@@ -6,7 +6,7 @@ test_name="$(basename "${0}" .sh)"
 project='metrics'
 repository='https://github.com/dropwizard/metrics.git'
 revision='v5.0.5'
-additional_build_flags=''
+additional_build_flags='-Dmaven.compiler.release=21'
 additional_source_directories=''
 shared_error_prone_flags='-XepOpt:Slf4jLoggerDeclaration:CanonicalStaticLoggerName=LOGGER'
 patch_error_prone_flags=''

integration-tests/metrics.sh

@@ -11,6 +11,19 @@
              .withLogConsumer(LogConsumer.withPrefix(sampleApp))
 --- a/pom.xml
 +++ b/pom.xml
+@@ -252,9 +252,9 @@
+           <release>${java.version}</release>
+           <source>${java.version}</source>
+           <target>${java.version}</target>
+-          <testRelease>17</testRelease>
+-          <testSource>17</testSource>
+-          <testTarget>17</testTarget>
++          <testRelease>${java.version}</testRelease>
++          <testSource>${java.version}</testSource>
++          <testTarget>${java.version}</testTarget>
+           <showWarnings>true</showWarnings>
+           <compilerArgs>
+             <arg>-Xlint:all,-serial,-processing,-options</arg>
 @@ -267,21 +267,32 @@
                -Xep:MissingSummary:OFF
                -Xep:LongDoubleConversion:OFF