Suggestions

Stephan202 · Stephan202 · commit c7dd3b2ce20c · 2025-10-31T20:03:47.000+01:00
diff --git a/error-prone-contrib/pom.xml b/error-prone-contrib/pom.xml
@@ -50,6 +50,7 @@
         <dependency>
             <groupId>com.fasterxml.jackson.core</groupId>
             <artifactId>jackson-core</artifactId>
+            <scope>provided</scope>
         </dependency>
         <dependency>
             <groupId>com.fasterxml.jackson.core</groupId>
diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/JacksonRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/JacksonRules.java
@@ -48,7 +48,10 @@ Optional<JsonNode> after(JsonNode node, String fieldName) {
     }
   }
 
-  /** Prefer {@link ObjectMapper#valueToTree(Object)} over more contrived alternatives. */
+  /**
+   * Prefer {@link ObjectMapper#valueToTree(Object)} over more contrived and less efficient
+   * alternatives.
+   */
   static final class ObjectMapperValueToTree {
     @BeforeTemplate
     JsonNode before(ObjectMapper objectMapper, Object object) throws JsonProcessingException {

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,10 @@ Optional<JsonNode> after(JsonNode node, String fieldName) {`
`48`	`48`	`}`
`49`	`49`	`}`
`50`	`50`
`51`		`- /** Prefer {@link ObjectMapper#valueToTree(Object)} over more contrived alternatives. */`
	`51`	`+ /**`
	`52`	`+ * Prefer {@link ObjectMapper#valueToTree(Object)} over more contrived and less efficient`
	`53`	`+ * alternatives.`
	`54`	`+ */`
`52`	`55`	`static final class ObjectMapperValueToTree {`
`53`	`56`	`@BeforeTemplate`
`54`	`57`	`JsonNode before(ObjectMapper objectMapper, Object object) throws JsonProcessingException {`