Skip to content

Commit 1ef9167

Browse files
committed
Delete popper dependency for Popover API.
1 parent d4ff358 commit 1ef9167

File tree

7 files changed

+4
-55
lines changed

7 files changed

+4
-55
lines changed

package-lock.json

Lines changed: 0 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
"url": "git+https://github.com/Templarian/MaterialDesign-Web-Component.git"
1818
},
1919
"dependencies": {
20-
"@popperjs/core": "^2.11.5",
2120
"@types/js-yaml": "^4.0.5",
2221
"dexie": "^3.2.1",
2322
"js-yaml": "^4.1.0",

src/pg/dropdown/dropdown.ts

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { Component, Prop, Part } from '@pictogrammers/element';
2-
import { createPopper } from '@popperjs/core';
32

43
import template from './dropdown.html';
54
import style from './dropdown.css';
@@ -28,24 +27,6 @@ export default class PgDropdown extends HTMLElement {
2827
}
2928

3029
wireUpPopover(node) {
31-
createPopper(node, this.$popover, {
32-
placement: 'bottom-start',
33-
modifiers: [
34-
{
35-
name: 'offset',
36-
options: {
37-
offset: [-4, 8],
38-
},
39-
},
40-
{
41-
name: 'arrow',
42-
options: {
43-
element: this.$arrow,
44-
padding: 0,
45-
},
46-
},
47-
]
48-
});
4930
this.$popover.style.visibility = 'hidden';
5031
node.addEventListener('click', (e) => {
5132
this.$popover.style.visibility = this.isVisible ? 'hidden' : 'visible';

src/pg/grid/grid.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { Component, Prop, Part, Local } from '@pictogrammers/element';
2-
// import { createPopper } from '@popperjs/core';
32
import { debounce, } from '../shared/debounce';
43
import PgScroll from '../scroll/scroll';
54

src/pg/menu/menu.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,5 @@
1010
border-style: solid;
1111
border-radius: 0.5rem;
1212
background-color: var(--pg-menu-background-color, #1E1E1E);
13+
box-shadow: var(--pg-menu-box-shadow, none);
1314
}

src/pg/overlayMenu/overlayMenu.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,6 @@
77
padding: 0;
88
border: 0;
99
background: transparent;
10+
overflow: visible;
11+
--pg-menu-box-shadow: 0 0.125rem 0.5rem rgba(0, 0, 0, 0.25);
1012
}

src/pg/picker/picker.ts

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { Component, Prop, Part } from '@pictogrammers/element';
22
import PgButton from '../button/button';
33
import PgGrid from '../grid/grid';
4-
import { createPopper } from '@popperjs/core';
54

65
import template from './picker.html';
76
import style from './picker.css';
@@ -24,24 +23,7 @@ export default class PgPicker extends HTMLElement { // extends PgButton = bug in
2423

2524
isVisible = false;
2625
connectedCallback() {
27-
/*createPopper(this.$button, this.$popover, {
28-
placement: 'bottom-start',
29-
modifiers: [
30-
{
31-
name: 'offset',
32-
options: {
33-
offset: [-4, 8],
34-
},
35-
},
36-
{
37-
name: 'arrow',
38-
options: {
39-
element: this.$arrow,
40-
padding: 0,
41-
},
42-
},
43-
]
44-
});
26+
/*
4527
this.$popover.style.visibility = 'hidden';
4628
this.$button.addEventListener('click', () => {
4729
this.$popover.style.visibility = this.isVisible ? 'hidden' : 'visible';

0 commit comments

Comments
 (0)