Skip to content

Commit 3359dc0

Browse files
committed
progress
1 parent 6751c4b commit 3359dc0

File tree

6 files changed

+41
-36
lines changed

6 files changed

+41
-36
lines changed

package-lock.json

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"remarkable": "^2.0.1"
2626
},
2727
"devDependencies": {
28-
"@pictogrammers/element": "0.0.67",
28+
"@pictogrammers/element": "0.0.68",
2929
"@pictogrammers/element-jest": "^0.1.10",
3030
"@pictogrammers/element-webpack": "^0.1.56",
3131
"cross-env": "^7.0.3",

src/pg/buttonMenu/README.md

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# `<pg-button-toggle>`
1+
# `<pg-button-menu>`
22

33
The `pg-button-toggle` component is essentially just a button with swappable slotted content. Commonly used with icons, but using `span` elements will allow assigning text content.
44

@@ -8,27 +8,20 @@ import PgButtonToggle from '@pictogrammers/components/pg/buttonToggle';
88
```
99

1010
```html
11-
<pg-button-toggle>
12-
<pg-icon slot="active" path="M...Z"></pg-icon>
13-
<pg-icon slot="inactive" path="M...Z"></pg-icon>
14-
</pg-button-toggle>
11+
<pg-button-menu part="menu"></pg-button-toggle>
1512
```
1613

17-
| Slots | Tested | Description |
18-
| ----------- | -------- | ----------- |
19-
| default | &#x2705; | Button contents. |
20-
2114
| Attribute | Tested | Description |
2215
| ---------- | -------- | ----------- |
23-
| block | | block sizing |
24-
| active | | Depressed visual state. |
16+
| menu | | block sizing |
2517
| start | | Internal Only |
2618
| end | | Internal Only |
2719
| center | | Internal Only |
2820

2921
| Events | Tested | Description |
3022
| ---------- | -------- | ----------- |
31-
| click | &#x2705; | Standard click. |
23+
| open | &#x2705; | Menu open. |
24+
| close | &#x2705; | Menu close. |
3225

3326
| CSS Variables | Default | Description |
3427
| ------------------- | --------- | ----------- |

src/pg/tree/README.md

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,13 @@ The `pg-tree` is used to render a tree list of items.
1010

1111
While setup for a normal file tree this can be used for any folder structure.
1212

13+
```typescript
14+
import '@pictogrammers/components/pg/tree';
15+
import '@pictogrammers/components/pg/treeItem';
16+
import '@pictogrammers/components/pg/treeButtonIcon';
17+
import PgTree, { SelectedTreeItem } from '@pictogrammers/components/pg/tree';
18+
```
19+
1320
## Events
1421

1522
- select
@@ -21,15 +28,16 @@ While setup for a normal file tree this can be used for any folder structure.
2128
```typescript
2229
this.$tree.addEventListener('select', (e: any) => {
2330
const { items } = e.detail;
31+
// items is a
2432
this.selectedItems = items;
2533
});
2634
```
2735

2836
```typescript
2937
this.$tree.addEventListener('rename', (e: any) => {
30-
const { indexes, label } = e.detail;
31-
const item = this.#getItem(indexes);
32-
item.label = label;
38+
const { item, label } = e.detail;
39+
const itemData = item.getData();
40+
itemData.label = label;
3341
});
3442
```
3543

src/pg/tree/__examples__/basic/basic.ts

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,9 @@ export default class XPgTreeBasic extends HTMLElement {
9696
});
9797
});
9898
this.$tree.addEventListener('rename', (e: any) => {
99-
const { indexes, label } = e.detail;
100-
const item = this.#getItem(indexes);
101-
item.label = label;
99+
const { item, label } = e.detail;
100+
const itemData = item.getData();
101+
itemData.label = label;
102102
});
103103
this.$tree.addEventListener('menu', (e: any) => {
104104
// menu
@@ -153,10 +153,4 @@ export default class XPgTreeBasic extends HTMLElement {
153153
});
154154
});
155155
}
156-
157-
#getItem(indexes: number[]) {
158-
return indexes.reduce((item, index) => {
159-
return item.items[index];
160-
}, this.$tree);
161-
}
162156
}

src/pg/tree/tree.ts

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export default class PgTree extends HTMLElement {
4242
this.dispatchEvent(new CustomEvent('action', {
4343
detail: {
4444
actionIndex: e.detail.actionIndex,
45-
item: this.#wrap(e.detail.indexes)
45+
item: this.#wrap(e.detail.indexes),
4646
}
4747
}));
4848
});
@@ -52,7 +52,17 @@ export default class PgTree extends HTMLElement {
5252
this.dispatchEvent(new CustomEvent('move', {
5353
detail: {
5454
item: this.#wrap(e.detail.indexes),
55-
position
55+
position,
56+
}
57+
}));
58+
});
59+
this.$items.addEventListener('rename', (e: any) => {
60+
const { indexes, label } = e.detail;
61+
e.stopPropagation();
62+
this.dispatchEvent(new CustomEvent('rename', {
63+
detail: {
64+
item: this.#wrap(indexes),
65+
label,
5666
}
5767
}));
5868
});

0 commit comments

Comments
 (0)