Skip to content

Commit a9a61d2

Browse files
committed
progress
1 parent 15a6369 commit a9a61d2

File tree

17 files changed

+83
-31
lines changed

17 files changed

+83
-31
lines changed

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"remarkable": "^2.0.1"
2626
},
2727
"devDependencies": {
28-
"@pictogrammers/element": "0.0.57",
28+
"@pictogrammers/element": "0.0.58",
2929
"@pictogrammers/element-jest": "^0.1.8",
3030
"@pictogrammers/element-webpack": "^0.1.48",
3131
"cross-env": "^7.0.3",

src/pg/inputCheckList/__examples__/basic/basic.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@ export default class XPgInputCheckListBasic extends HTMLElement {
2020
{ value: 'uuid3', label: 'Item 3', disabled: true },
2121
{ value: 'uuid4', label: 'Item 4' }
2222
);
23-
this.$value.innerText = this.$input.value.join(',');
23+
this.$value.textContent = this.$input.value.join(',');
2424
this.$input.addEventListener('change', this.handleChange.bind(this));
2525
}
2626

2727
handleChange(e) {
2828
const { value } = e.detail;
29-
this.$value.innerText = value.join(',');
29+
this.$value.textContent = value.join(',');
3030
}
3131
}

src/pg/inputPixelEditor/__examples__/basic/basic.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,12 +152,12 @@ export default class XPgInputPixelEditorBasic extends HTMLElement {
152152

153153
handleChange(e: CustomEvent) {
154154
const { value } = e.detail;
155-
this.$value1.innerText = value.join('--');
155+
this.$value1.textContent = value.join('--');
156156
}
157157

158158
handleInput(e: CustomEvent) {
159159
const { value } = e.detail;
160-
this.$value2.innerText = value;
160+
this.$value2.textContent = value;
161161
}
162162

163163
handleDebug(e: CustomEvent) {

src/pg/inputRange/__examples__/basic/basic.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@ export default class XPgInputRangeBasic extends HTMLElement {
1414
@Part() $value2: HTMLSpanElement;
1515

1616
connectedCallback() {
17-
this.$input.addEventListener('change', this.handleChange.bind(this));
18-
this.$input.addEventListener('input', this.handleInput.bind(this));
17+
this.$input.addEventListener('change', this.#handleChange.bind(this));
18+
this.$input.addEventListener('input', this.#handleInput.bind(this));
1919
}
2020

21-
handleChange(e: CustomEvent) {
21+
#handleChange(e: CustomEvent) {
2222
const { value } = e.detail;
2323
this.$value1.innerText = value;
2424
}
2525

26-
handleInput(e: CustomEvent) {
26+
#handleInput(e: CustomEvent) {
2727
const { value } = e.detail;
2828
this.$value2.innerText = value;
2929
}

src/pg/inputRange/inputRange.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,12 @@ export default class PgInputRange extends HTMLElement {
2323
}
2424

2525
connectedCallback() {
26-
this.$input.addEventListener('change', this.handleChange.bind(this));
27-
this.$input.addEventListener('input', this.handleInput.bind(this));
26+
this.$input.addEventListener('change', this.#handleChange.bind(this));
27+
this.$input.addEventListener('input', this.#handleInput.bind(this));
2828
}
2929

30-
handleChange(e) {
30+
#handleChange(e: any) {
31+
e.stopPropagation();
3132
const { value } = e.target;
3233
this.dispatchEvent(
3334
new CustomEvent('change', {
@@ -39,7 +40,8 @@ export default class PgInputRange extends HTMLElement {
3940
);
4041
}
4142

42-
handleInput(e) {
43+
#handleInput(e: any) {
44+
e.stopPropagation();
4345
const { value } = e.target;
4446
this.dispatchEvent(
4547
new CustomEvent('input', {

src/pg/inputSelect/inputSelect.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
grid-row: 1;
2626
grid-column: 1;
2727
padding: 0.5rem 0.75rem;
28+
font-size: var(--pg-input-select-font-size, 1rem);
2829
}
2930

3031
[part=chevron] {

src/pg/inputText/__examples__/basic/basic.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,17 @@ export default class XPgInputTextBasic extends HTMLElement {
1414
@Part() $value2: HTMLSpanElement;
1515

1616
connectedCallback() {
17-
this.$input.addEventListener('change', this.handleChange.bind(this));
18-
this.$input.addEventListener('input', this.handleInput.bind(this));
17+
this.$input.addEventListener('change', this.#handleChange.bind(this));
18+
this.$input.addEventListener('input', this.#handleInput.bind(this));
1919
}
2020

21-
handleChange(e: CustomEvent) {
21+
#handleChange(e: CustomEvent) {
2222
const { value } = e.detail;
23-
this.$value1.innerText = value;
23+
this.$value1.textContent = value;
2424
}
2525

26-
handleInput(e: CustomEvent) {
26+
#handleInput(e: CustomEvent) {
2727
const { value } = e.detail;
28-
this.$value2.innerText = value;
28+
this.$value2.textContent = value;
2929
}
3030
}

src/pg/menu/__examples__/basic/basic.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ export default class XPgMenuBasic extends HTMLElement {
1414
connectedCallback() {
1515
this.$menu.items = [{
1616
label: 'Item 1',
17-
value: 'item1'
17+
value: 'item1',
18+
checked: true
1819
},
1920
{
2021
label: 'Item 2',
@@ -24,6 +25,15 @@ export default class XPgMenuBasic extends HTMLElement {
2425
}
2526

2627
#handleSelect(e: any) {
28+
this.$menu.items.forEach(item => {
29+
if (item.checked && item.index !== e.detail.index) {
30+
item.checked = false;
31+
}
32+
if (!item.checked && item.index === e.detail.index) {
33+
item.checked = true;
34+
}
35+
})
36+
// update clicked result
2737
this.$result.textContent = JSON.stringify(e.detail);
2838
}
2939
}
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
11
<div class="example">
22
<pg-menu-item part="item"></pg-menu-item>
3+
</div>
4+
<div>
5+
<button>Toggle <code>disabled</code></button>
6+
<button>Toggle <code>checked</code></button>
37
</div>

0 commit comments

Comments
 (0)