Skip to content

Commit aa72100

Browse files
committed
Simplify overlay for production builds.
1 parent f575c59 commit aa72100

File tree

4 files changed

+17
-19
lines changed

4 files changed

+17
-19
lines changed

package-lock.json

Lines changed: 13 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"remarkable": "^2.0.1"
2626
},
2727
"devDependencies": {
28-
"@pictogrammers/element": "0.0.54",
28+
"@pictogrammers/element": "0.0.57",
2929
"@pictogrammers/element-jest": "^0.1.8",
3030
"@pictogrammers/element-webpack": "^0.1.48",
3131
"cross-env": "^7.0.3",

src/pg/menuItem/menuItem.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,13 @@ export default class PgMenuItem extends HTMLElement {
4242
this.dispatchEvent(new CustomEvent('down', {
4343
detail: { index: this.index }
4444
}));
45+
e.preventDefault();
4546
break;
4647
case 'ArrowUp':
4748
this.dispatchEvent(new CustomEvent('up', {
4849
detail: { index: this.index }
4950
}));
51+
e.preventDefault();
5052
break;
5153
}
5254
});

src/pg/overlay/overlay.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,12 @@
11
import { Component } from '@pictogrammers/element';
22

3-
function camelToDash(str: string): string {
4-
return str.replace(/([a-zA-Z])(?=[A-Z])/g, '$1-').toLowerCase()
5-
}
6-
73
const layers: any[] = [];
84
const promises: any[] = [];
95

106
@Component()
117
export default class PgOverlay extends HTMLElement {
128
static open(props: any = {}): Promise<any> {
13-
var ele = document.createElement(camelToDash(this.name));
9+
var ele = document.createElement(this.name);
1410
Object.assign(ele, props);
1511
document.body.appendChild(ele);
1612
layers.push(ele);

0 commit comments

Comments
 (0)