fix: better cleanup queue work in renderer ext

Author: hoffstadt

extensions/pl_renderer_ext.c

@@ -1386,18 +1386,34 @@ pl_renderer_resize_view(plView* ptView, plVec2 tDimensions)
     plRenderPassAttachments atPickAttachmentSets[PL_MAX_FRAMES_IN_FLIGHT] = {0};
 
 
-    // queue old resources for deletion
-    gptGfx->queue_texture_for_deletion(ptDevice, ptView->tFinalTexture);
-    gptGfx->queue_texture_for_deletion(ptDevice, ptView->atUVMaskTexture0);
-    gptGfx->queue_texture_for_deletion(ptDevice, ptView->atUVMaskTexture1);
-    gptGfx->queue_texture_for_deletion(ptDevice, ptView->tRawOutputTexture);
-    gptGfx->queue_texture_for_deletion(ptDevice, ptView->tAlbedoTexture);
-    gptGfx->queue_texture_for_deletion(ptDevice, ptView->tNormalTexture);
-    gptGfx->queue_texture_for_deletion(ptDevice, ptView->tAOMetalRoughnessTexture);
-    gptGfx->queue_texture_for_deletion(ptDevice, ptView->tDepthTexture);
-    gptGfx->queue_bind_group_for_deletion(ptDevice, ptView->tLightingBindGroup);
+    uint64_t uOldValue = gptGfx->get_semaphore_value(ptDevice, gptStarter->get_current_timeline_semaphore());
+
+    if(uOldValue >= gptStarter->get_current_timeline_value())
+    {
+        gptGfx->destroy_texture(ptDevice, ptView->tFinalTexture);
+        gptGfx->destroy_texture(ptDevice, ptView->atUVMaskTexture0);
+        gptGfx->destroy_texture(ptDevice, ptView->atUVMaskTexture1);
+        gptGfx->destroy_texture(ptDevice, ptView->tRawOutputTexture);
+        gptGfx->destroy_texture(ptDevice, ptView->tAlbedoTexture);
+        gptGfx->destroy_texture(ptDevice, ptView->tNormalTexture);
+        gptGfx->destroy_texture(ptDevice, ptView->tAOMetalRoughnessTexture);
+        gptGfx->destroy_texture(ptDevice, ptView->tDepthTexture);
+        gptGfx->destroy_texture(ptDevice, ptView->tPickTexture);
+    }
+    else
+    {
+        gptGfx->queue_texture_for_deletion(ptDevice, ptView->tFinalTexture);
+        gptGfx->queue_texture_for_deletion(ptDevice, ptView->atUVMaskTexture0);
+        gptGfx->queue_texture_for_deletion(ptDevice, ptView->atUVMaskTexture1);
+        gptGfx->queue_texture_for_deletion(ptDevice, ptView->tRawOutputTexture);
+        gptGfx->queue_texture_for_deletion(ptDevice, ptView->tAlbedoTexture);
+        gptGfx->queue_texture_for_deletion(ptDevice, ptView->tNormalTexture);
+        gptGfx->queue_texture_for_deletion(ptDevice, ptView->tAOMetalRoughnessTexture);
+        gptGfx->queue_texture_for_deletion(ptDevice, ptView->tDepthTexture);
+        gptGfx->queue_texture_for_deletion(ptDevice, ptView->tPickTexture);
+    }
 
-    gptGfx->queue_texture_for_deletion(ptDevice, ptView->tPickTexture);
+    gptGfx->queue_bind_group_for_deletion(ptDevice, ptView->tLightingBindGroup);
     ptView->tPickTexture = pl__renderer_create_texture(&tPickTextureDesc, "pick", 0, PL_TEXTURE_USAGE_SAMPLED);
 
     // textures
@@ -2199,9 +2215,9 @@ pl_renderer_prepare_scene(plScene* ptScene)
     pl_sb_reset(ptScene->sbtLightShadowData);
 
     const plBeginCommandInfo tShadowBeginInfo = {
-        .uWaitSemaphoreCount   = 1,
-        .atWaitSempahores      = {gptStarter->get_current_timeline_semaphore()},
-        .auWaitSemaphoreValues = {gptStarter->get_current_timeline_value()},
+        .uWaitSemaphoreCount   = 2,
+        .atWaitSempahores      = {gptStarter->get_current_timeline_semaphore(), gptStarter->get_last_timeline_semaphore()},
+        .auWaitSemaphoreValues = {gptStarter->get_current_timeline_value(), ptScene->uLastSemValueForShadow},
     };
 
     plCommandBuffer* ptShadowCmdBuffer = gptGfx->request_command_buffer(ptCmdPool, "scene shadows");
@@ -2939,6 +2955,7 @@ pl_renderer_render_view(plView* ptView, plCamera* ptCamera, plCamera* ptCullCame
         .atSignalSempahores      = {gptStarter->get_current_timeline_semaphore()},
         .auSignalSemaphoreValues = {gptStarter->increment_current_timeline_value()}
     };
+    ptScene->uLastSemValueForShadow = gptStarter->get_current_timeline_value();
     gptGfx->submit_command_buffer(ptSceneCmdBuffer, &tSceneSubmitInfo);
     gptGfx->return_command_buffer(ptSceneCmdBuffer);
 
@@ -3214,6 +3231,8 @@ pl_renderer_render_view(plView* ptView, plCamera* ptCamera, plCamera* ptCullCame
         .atSignalSempahores      = {gptStarter->get_current_timeline_semaphore()},
         .auSignalSemaphoreValues = {gptStarter->increment_current_timeline_value()}
     };
+    ptScene->aulStartTimelineValue[uFrameIdx] = tPostSubmitInfo.auSignalSemaphoreValues[0];
+
     gptGfx->submit_command_buffer(ptPostCmdBuffer, &tPostSubmitInfo);
     gptGfx->return_command_buffer(ptPostCmdBuffer);
 

extensions/pl_renderer_internal.h

@@ -341,6 +341,8 @@ typedef struct _plScene
     bool           bActive;
     plShaderHandle tLightingShader;
     plShaderHandle tEnvLightingShader;
+    uint64_t uLastSemValueForShadow;
+    uint64_t aulStartTimelineValue[PL_MAX_FRAMES_IN_FLIGHT];
 
     // skybox resources (optional)
     plDrawable        tSkyboxDrawable;