WIP cube

WIP cube 2

WIP

Author: hoffstadt

extensions/pl_graphics_ext.c

@@ -346,7 +346,6 @@ pl__cleanup_common_device(plDevice* ptDevice)
     pl_sb_free(ptDevice->sbtBufferFreeIndices);
     pl_sb_free(ptDevice->sbtTexturesCold);
     pl_sb_free(ptDevice->sbtSamplersCold);
-    pl_sb_free(ptDevice->sbtBindGroupsCold);
     pl_sb_free(ptDevice->sbtRenderPassesCold);
     pl_sb_free(ptDevice->sbtTextureFreeIndices);
     pl_sb_free(ptDevice->sbtRenderPassLayoutsCold);
@@ -357,6 +356,12 @@ pl__cleanup_common_device(plDevice* ptDevice)
     pl_sb_free(ptDevice->sbtRenderPassLayoutFreeIndices);
     pl_sb_free(ptDevice->sbtRenderPassFreeIndices);
 
+    for(uint32_t i = 0; i < pl_sb_size(ptDevice->sbtBindGroupsCold); i++)
+    {
+        pl_sb_free(ptDevice->sbtBindGroupsCold[i]._sbtTextures);
+    }
+    pl_sb_free(ptDevice->sbtBindGroupsCold);
+
     plTimelineSemaphore* ptCurrentSemaphore = ptDevice->ptSemaphoreFreeList;
     while(ptCurrentSemaphore)
     {

extensions/pl_graphics_ext.h

@@ -464,6 +464,7 @@ typedef struct _plTextureViewDesc
     uint32_t        uBaseLayer;
     uint32_t        uLayerCount;
     plTextureHandle tTexture;
+    plTextureType   tType;
     const char*     pcDebugName; // default: "unnamed texture view"
 } plTextureViewDesc;
 

extensions/pl_graphics_metal.m

@@ -1054,6 +1054,7 @@
     ptNewTexture->tView = *ptViewDesc;
     ptNewTexture->tDesc.uMips = ptViewDesc->uMips;
     ptNewTexture->tDesc.uLayers = ptViewDesc->uLayerCount;
+    ptNewTexture->tDesc.tType = ptViewDesc->tType;
     ptNewTexture->tView.uBaseMip = 0;
     ptNewTexture->tView.uBaseLayer = 0;
 
@@ -1105,7 +1106,9 @@
             levels:tLevelRange
             slices:tSliceRange];
 
-    ptNewMetalTexture->tTexture.label = [NSString stringWithUTF8String:ptViewDesc->pcDebugName];
+    if(ptNewTexture->tView.pcDebugName == NULL)
+        ptNewTexture->tView.pcDebugName = "unnamed texture";
+    ptNewMetalTexture->tTexture.label = [NSString stringWithUTF8String:ptNewTexture->tView.pcDebugName];
     ptNewMetalTexture->uHeap = ptOldMetalTexture->uHeap;
     return tHandle;
 }
@@ -2689,6 +2692,7 @@
             pl_sb_free(ptDevice->sbtRenderPassesHot[i].atRenderPassDescriptors[j].sbptRenderPassDescriptor);
         }
     }
+    pl_sb_free(ptDevice->sbuFreeHeaps);
     pl_sb_free(ptDevice->sbtTexturesHot);
     pl_sb_free(ptDevice->sbtSamplersHot);
     pl_sb_free(ptDevice->sbtBindGroupsHot);

extensions/pl_graphics_vulkan.c

@@ -1265,18 +1265,19 @@ pl_create_texture_view(plDevice* ptDevice, const plTextureViewDesc* ptViewDesc)
     plTexture* ptOriginalTexture = pl__get_texture(ptDevice, ptViewDesc->tTexture);
     plTexture* ptNewTexture = pl__get_texture(ptDevice, ptViewDesc->tTexture);
     ptNewTexture->tDesc = ptOriginalTexture->tDesc;
+    ptNewTexture->tDesc.tType = ptViewDesc->tType;
     ptNewTexture->tView = *ptViewDesc;
     plVulkanTexture* ptOldVulkanTexture = &ptDevice->sbtTexturesHot[ptViewDesc->tTexture.uIndex];
     plVulkanTexture* ptNewVulkanTexture = &ptDevice->sbtTexturesHot[tHandle.uIndex];
 
     //~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~create view~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
     VkImageViewType tImageViewType = 0;
-    if (ptOriginalTexture->tDesc.tType == PL_TEXTURE_TYPE_CUBE)
+    if (ptNewTexture->tDesc.tType == PL_TEXTURE_TYPE_CUBE)
         tImageViewType = VK_IMAGE_VIEW_TYPE_CUBE;
-    else if (ptOriginalTexture->tDesc.tType == PL_TEXTURE_TYPE_2D)
+    else if (ptNewTexture->tDesc.tType == PL_TEXTURE_TYPE_2D)
         tImageViewType = VK_IMAGE_VIEW_TYPE_2D;
-    else if (ptOriginalTexture->tDesc.tType == PL_TEXTURE_TYPE_2D_ARRAY)
+    else if (ptNewTexture->tDesc.tType == PL_TEXTURE_TYPE_2D_ARRAY)
         tImageViewType = VK_IMAGE_VIEW_TYPE_2D; // VK_IMAGE_VIEW_TYPE_2D_ARRAY;
     else
     {
@@ -4329,7 +4330,7 @@ pl__fill_common_render_pass_data(plRenderPassLayoutDesc* ptDesc, plRenderPassLay
         .dstStageMask    = VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT | VK_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT | VK_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT | VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT,
         .srcAccessMask   = VK_ACCESS_SHADER_WRITE_BIT | VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT | VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT | VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT,
         .dstAccessMask   = VK_ACCESS_SHADER_READ_BIT | VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT | VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT | VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT,
-        .dependencyFlags = 0
+        .dependencyFlags = VK_DEPENDENCY_BY_REGION_BIT
     };
 
     ptDataOut->atSubpassDependencies[1] = (VkSubpassDependency){

extensions/pl_renderer_ext.c

@@ -1904,7 +1904,7 @@ pl_refr_reload_scene_shaders(uint32_t uSceneHandle)
 
     pl_refr_create_global_shaders();
 
-    int iSceneWideRenderingFlags = 0;
+    int iSceneWideRenderingFlags = PL_RENDERING_FLAG_SHADOWS;
     if(gptData->bPunctualLighting)
         iSceneWideRenderingFlags |= PL_RENDERING_FLAG_USE_PUNCTUAL;
     if(gptData->bImageBasedLighting)
@@ -1998,7 +1998,7 @@ pl_refr_reload_scene_shaders(uint32_t uSceneHandle)
             tLightingShaderDesc.atConstants[i].tType = PL_DATA_TYPE_INT;
         }
         ptScene->tLightingShader = gptGfx->create_shader(gptData->ptDevice, &tLightingShaderDesc);
-        aiLightingConstantData[0] = gptData->bPunctualLighting ? PL_RENDERING_FLAG_USE_PUNCTUAL : 0;
+        aiLightingConstantData[0] = gptData->bPunctualLighting ? (PL_RENDERING_FLAG_USE_PUNCTUAL | PL_RENDERING_FLAG_SHADOWS) : 0;
         ptScene->tEnvLightingShader = gptGfx->create_shader(gptData->ptDevice, &tLightingShaderDesc);
     }
 
@@ -2201,7 +2201,7 @@ pl_refr_finalize_scene(uint32_t uSceneHandle)
         gptGfx->update_bind_group(gptData->ptDevice, ptScene->tSkinBindGroup0, &tBGData0);
     }
 
-    int iSceneWideRenderingFlags = 0;
+    int iSceneWideRenderingFlags = PL_RENDERING_FLAG_SHADOWS;
     if(gptData->bPunctualLighting)
         iSceneWideRenderingFlags |= PL_RENDERING_FLAG_USE_PUNCTUAL;
     if(gptData->bImageBasedLighting)
@@ -2293,7 +2293,7 @@ pl_refr_finalize_scene(uint32_t uSceneHandle)
             tLightingShaderDesc.atConstants[i].tType = PL_DATA_TYPE_INT;
         }
         ptScene->tLightingShader = gptGfx->create_shader(gptData->ptDevice, &tLightingShaderDesc);
-        aiLightingConstantData[0] = gptData->bPunctualLighting ? PL_RENDERING_FLAG_USE_PUNCTUAL : 0;
+        aiLightingConstantData[0] = gptData->bPunctualLighting ? (PL_RENDERING_FLAG_USE_PUNCTUAL | PL_RENDERING_FLAG_SHADOWS) : 0;
         ptScene->tEnvLightingShader = gptGfx->create_shader(gptData->ptDevice, &tLightingShaderDesc);
     }