Skip to content

Commit 462a25b

Browse files
committed
remove hasLoaded flag and use media's currentSrc instead
1 parent 32f4d40 commit 462a25b

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

packages/mux-player/src/base.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ function getProps(el: MuxPlayerElement, state?: any): MuxTemplateProps {
127127
playbackId: el.playbackId,
128128
hasSrc: !!el.playbackId || !!el.src || !!el.currentSrc,
129129
poster: el.poster,
130-
storyboard: el.hasLoaded && el.storyboard,
130+
storyboard: el.media?.currentSrc && el.storyboard,
131131
storyboardSrc: el.getAttribute(PlayerAttributes.STORYBOARD_SRC),
132132
fullscreenElement: el.getAttribute(PlayerAttributes.FULLSCREEN_ELEMENT),
133133
placeholder: el.getAttribute('placeholder'),
@@ -289,7 +289,6 @@ class MuxPlayerElement extends VideoApiElement implements IMuxPlayerElement {
289289
#isInit = false;
290290
#tokens: Tokens = {};
291291
#userInactive = true;
292-
#hasLoaded = false;
293292
#hotkeys = new AttributeTokenList(this, 'hotkeys');
294293
#state: Partial<MuxTemplateProps> = {
295294
...initialState,
@@ -382,10 +381,7 @@ class MuxPlayerElement extends VideoApiElement implements IMuxPlayerElement {
382381
this.media?.addEventListener('streamtypechange', () => this.#render());
383382

384383
// NOTE: Make sure we re-render when <source> tags are appended so hasSrc is updated.
385-
this.media?.addEventListener('loadstart', () => {
386-
this.#hasLoaded = true;
387-
this.#render();
388-
});
384+
this.media?.addEventListener('loadstart', () => this.#render());
389385
}
390386

391387
#setupCSSProperties() {
@@ -827,10 +823,6 @@ class MuxPlayerElement extends VideoApiElement implements IMuxPlayerElement {
827823
return this.mediaController?.hasAttribute(MediaUIAttributes.MEDIA_HAS_PLAYED) ?? false;
828824
}
829825

830-
get hasLoaded() {
831-
return this.#hasLoaded;
832-
}
833-
834826
get inLiveWindow() {
835827
return this.mediaController?.hasAttribute(MediaUIAttributes.MEDIA_TIME_IS_LIVE);
836828
}

0 commit comments

Comments
 (0)