experiment profile rejects quotes

Author: CamDavidsonPilon

core/pioreactor/actions/leader/experiment_profile.py

@@ -127,19 +127,30 @@ def evaluate_bool_expression(bool_expression: BoolExpression, env: dict) -> bool
     return parse_profile_expression_to_bool(bool_expression, env=env)
 
 
-def check_syntax_of_bool_expression(bool_expression: BoolExpression) -> bool:
+def check_syntax_of_bool_expression(bool_expression: BoolExpression) -> str | None:
     from pioreactor.experiment_profiles.parser import check_syntax
 
     if isinstance(bool_expression, bool):
-        return True
+        return None
 
     if is_bracketed_expression(bool_expression):
         bool_expression = strip_expression_brackets(bool_expression)
 
+    import re
+
+    # Detect quoted strings early to provide a clearer error.
+    quoted_matches = re.findall(r'"[^"]*"|\'[^\']*\'', bool_expression)
+    if quoted_matches:
+        return (
+            "Quoted string literals are not supported in profile expressions. " f"Found {quoted_matches[0]}."
+        )
+
     # TODO: in a common expressions, users can use ::word:work which is technically not valid syntax. For checking, we replace with garbage
     bool_expression = bool_expression.replace("::", "dummy:", 1)
 
-    return check_syntax(bool_expression)
+    if check_syntax(bool_expression):
+        return None
+    return "Syntax error in expression."
 
 
 def check_if_job_running(unit: pt.Unit, job: str) -> bool:
@@ -895,14 +906,20 @@ def _verify_experiment_profile(profile: struct.Profile) -> bool:
 
     for job in actions_per_job:
         for action in actions_per_job[job]:
-            if hasattr(action, "if_") and action.if_ and not check_syntax_of_bool_expression(action.if_):  # type: ignore
-                raise SyntaxError(f"Syntax error in {job}.{action}: `{action.if_}`")
-
-            if hasattr(action, "condition_") and action.condition_ and not check_syntax_of_bool_expression(action.condition_):  # type: ignore
-                raise SyntaxError(f"Syntax error in {job}.{action}: `{action.condition_}`")
-
-            if hasattr(action, "while_") and action.while_ and not check_syntax_of_bool_expression(action.while_):  # type: ignore
-                raise SyntaxError(f"Syntax error in {job}.{action}: `{action.while_}`")
+            if hasattr(action, "if_") and action.if_:
+                error = check_syntax_of_bool_expression(action.if_)  # type: ignore
+                if error:
+                    raise SyntaxError(f"{error} In {job}.{action}: `{action.if_}`")
+
+            if hasattr(action, "condition_") and action.condition_:
+                error = check_syntax_of_bool_expression(action.condition_)  # type: ignore
+                if error:
+                    raise SyntaxError(f"{error} In {job}.{action}: `{action.condition_}`")
+
+            if hasattr(action, "while_") and action.while_:
+                error = check_syntax_of_bool_expression(action.while_)  # type: ignore
+                if error:
+                    raise SyntaxError(f"{error} In {job}.{action}: `{action.while_}`")
 
     return True
 

core/pioreactor/experiment_profiles/profiles_spec.txt

@@ -91,6 +91,8 @@ pioreactors:
 # - Numbers: integer or float (e.g., 1, -2.5)
 # - Booleans: true, false (case-insensitive)
 # - Names resolve to values provided in the expression environment (inputs, etc.); otherwise they remain strings.
+#   Note: quoted string literals are not supported. Use bare tokens for string comparison
+#   (e.g., `state == ready`, not `state == "ready"`).
 #
 # Operators
 # - Arithmetic: +, -, *, / (raises on division by zero), ** (exponent)
@@ -108,7 +110,7 @@ pioreactors:
 # MQTT lookups
 # - <unit>:<job>:<setting>[.<nested_key>]*
 # - ::<job>:<setting>[.<nested_key>]* (uses current unit)
-#   Examples: unit():od_reading:od600, ::stirring:setting.target_rpm
+#   Examples: unit():od_reading:od600, ::stirring:setting.target_rpm, pio02:monitor:$state
 #   Fails if worker is inactive or topic missing.
 #
 # Conversion rules

core/pioreactor/web/static/asset-manifest.json

@@ -1,7 +1,7 @@
 {
   "files": {
     "main.css": "/static/static/css/main.9c7a48b7.css",
-    "main.js": "/static/static/js/main.8b8d45fc.js",
+    "main.js": "/static/static/js/main.b46e3258.js",
     "static/media/pioreactor_cloud.webp": "/static/static/media/pioreactor_cloud.b15b29e435797dc69d76.webp",
     "static/media/roboto-all-500-normal.woff": "/static/static/media/roboto-all-500-normal.0ab669b7a0d19b178f57.woff",
     "static/media/roboto-all-700-normal.woff": "/static/static/media/roboto-all-700-normal.a457fde362a540fcadff.woff",
@@ -30,10 +30,10 @@
     "static/media/roboto-greek-ext-700-normal.woff2": "/static/static/media/roboto-greek-ext-700-normal.bd9854c751441ccc1a70.woff2",
     "index.html": "/static/index.html",
     "main.9c7a48b7.css.map": "/static/static/css/main.9c7a48b7.css.map",
-    "main.8b8d45fc.js.map": "/static/static/js/main.8b8d45fc.js.map"
+    "main.b46e3258.js.map": "/static/static/js/main.b46e3258.js.map"
   },
   "entrypoints": [
     "static/css/main.9c7a48b7.css",
-    "static/js/main.8b8d45fc.js"
+    "static/js/main.b46e3258.js"
   ]
 }

core/pioreactor/web/static/index.html

@@ -1 +1 @@
-<!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="/static/favicon.ico"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="Pioreactor"/><link rel="apple-touch-icon" href="/static/logo192.png"/><link rel="manifest" href="/static/manifest.json"/><script defer="defer" src="/static/static/js/main.8b8d45fc.js"></script><link href="/static/static/css/main.9c7a48b7.css" rel="stylesheet"></head><body><div id="root"></div></body></html>
+<!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="/static/favicon.ico"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="Pioreactor"/><link rel="apple-touch-icon" href="/static/logo192.png"/><link rel="manifest" href="/static/manifest.json"/><script defer="defer" src="/static/static/js/main.b46e3258.js"></script><link href="/static/static/css/main.9c7a48b7.css" rel="stylesheet"></head><body><div id="root"></div></body></html>

core/pioreactor/web/static/static/js/main.8b8d45fc.js

@@ -878,6 +878,20 @@ def test_profiles_in_github_repo() -> None:
         assert _verify_experiment_profile(profile)
 
 
+def test_verify_rejects_quoted_string_literals_in_if() -> None:
+    action = Start(hours_elapsed=0.0, if_='${{ pio02:monitor:$state == "ready" }}')
+    profile = Profile(
+        experiment_profile_name="test_profile",
+        plugins=[],
+        common=CommonBlock(jobs={"job1": Job(actions=[action])}),
+        pioreactors={},
+        metadata=Metadata(author="test_author"),
+    )
+
+    with pytest.raises(SyntaxError, match=r'Quoted string literals are not supported.*"ready"'):
+        _verify_experiment_profile(profile)
+
+
 @patch("pioreactor.actions.leader.experiment_profile._load_experiment_profile")
 def test_api_requests_are_made(
     mock__load_experiment_profile,

core/pioreactor/web/static/static/js/main.b46e3258.js

@@ -95,6 +95,24 @@ function displayVariable(string){
   return  <Chip size="small" sx={{marginTop: "0px", marginBottom: "3px"}}  label={<span style={expression}>{String(string).trim()}</span>} />
 }
 
+function findQuotedString(expressionString){
+  if (typeof expressionString !== 'string') return null;
+  const match = expressionString.match(/"[^"]*"|'[^']*'/);
+  return match ? match[0] : null;
+}
+
+function findFirstDisallowedCharacter(expressionString){
+  if (typeof expressionString !== 'string') return null;
+  const allowedPattern = /^[a-zA-Z0-9_\$\.\:\s\(\)\+\-\*\/<>=!]+$/;
+  if (allowedPattern.test(expressionString)) return null;
+  for (let i = 0; i < expressionString.length; i += 1) {
+    if (!allowedPattern.test(expressionString[i])) {
+      return expressionString[i];
+    }
+  }
+  return null;
+}
+
 function almostExpressionSyntax(string){
     const almostPattern1 = /{+(.*?)}+/;
     const almostPattern2 = /{{(.*?)}}/;
@@ -152,6 +170,14 @@ function processBracketedExpression(value) {
     var match = pattern.exec(String(value));
 
     if (match) {
+      const quoted = findQuotedString(match[1]);
+      if (quoted) {
+        return <UnderlineSpan title={`Quoted string literals aren't supported. Found ${quoted}.`}>??</UnderlineSpan>;
+      }
+      const invalidChar = findFirstDisallowedCharacter(match[1]);
+      if (invalidChar) {
+        return <UnderlineSpan title={`Invalid character in expression: ${invalidChar}`}>??</UnderlineSpan>;
+      }
       return displayExpression(match[1])
     }
 
@@ -570,6 +596,9 @@ export const DisplayProfile = ({ data }) => {
         <Typography variant="h6"><ViewTimelineOutlinedIcon sx={{verticalAlign: "middle", margin:"0px 3px"}}/>{data?.experiment_profile_name || <UnderlineSpan title="missing `experiment_profile_name`">??</UnderlineSpan>}</Typography>
         <AuthorSection author={data?.metadata?.author} />
         <DescriptionSection description={data?.metadata?.description} />
+        <Typography variant="body2" color="text.secondary" sx={{ mb: 1 }}>
+          Note: quoted strings aren&apos;t supported in profile expressions. Use bare tokens like <span style={expression}>ready</span>, not <span style={expression}>&quot;ready&quot;</span>.
+        </Typography>
         <br/>
         <PluginsSection plugins={data?.plugins} />
         <ParametersSection parameters={data?.inputs} />